]> https://gitweb.dealii.org/ - dealii.git/commit
Get rid of create_triangulation_compatibility in the UNV reader. 12039/head
authorDavid Wells <drwells@email.unc.edu>
Tue, 13 Apr 2021 14:22:31 +0000 (10:22 -0400)
committerDavid Wells <drwells@email.unc.edu>
Wed, 14 Apr 2021 02:53:39 +0000 (22:53 -0400)
commit60645f9b1084b014e1d0e76d0f2b92a1b050430a
tree7bfa525d28fae22b48abc13cf10356f67f0ad344
parent8e208ae9dca8349c52b230514722463eb6fd51f4
Get rid of create_triangulation_compatibility in the UNV reader.

This case is interesting since the current code only works by coincidence. Our
test files have vertices numbered like

    2 ---- 3
    |      |
    |      |
    1 ---- 0

which we read in in the old-style (UCD) numbering, which is like mirroring
across the y-axis. This causes all the cells to have a negative measure (but they
aren't pinched). GridReordering then fixes this by swapping vertices 1 and 3 of
every single cell - i.e., adding another -1 factor to the measure, which now
causes all cells to have positive measure. Something similar happens in 3D.

As far as I can tell there is no widely accepted node numbering for UNV like
there is for everything else so I am going by what Salome generates. Since we
now use their numbering directly (instead of something that worked by
coincidence) the output files are slightly different but all cells do end up
looking correct (nothing is twisted when we visualize with VTK).
doc/news/changes/incompatibilities/20210313DavidWells [new file with mode: 0644]
include/deal.II/grid/reference_cell.h
source/grid/grid_in.cc
source/grid/reference_cell.cc
tests/grid/grid_in_unv_2d.output
tests/grid/grid_in_unv_3d.output
tests/grid/grid_in_unv_3d_02.output

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.