]> https://gitweb.dealii.org/ - dealii-svn.git/commitdiff
Leave two TODOs.
authorbangerth <bangerth@0785d39b-7218-0410-832d-ea1e28bc413d>
Thu, 25 Aug 2011 19:13:06 +0000 (19:13 +0000)
committerbangerth <bangerth@0785d39b-7218-0410-832d-ea1e28bc413d>
Thu, 25 Aug 2011 19:13:06 +0000 (19:13 +0000)
git-svn-id: https://svn.dealii.org/trunk@24203 0785d39b-7218-0410-832d-ea1e28bc413d

deal.II/source/base/utilities.cc

index 03802b0f5f41ad959d7d06e0e9d5306ffcebc6f5..d4984d80acb601459025cf93bf76de3891c59020 100644 (file)
@@ -142,10 +142,14 @@ namespace Utilities
 
     int i = max_int;
     ss >> i;
-
                                      // check for errors
     AssertThrow (i != max_int, ExcCantConvertString (s));
 
+//TODO: The test for errors above doesn't work, as can easily be
+//verified. furthermore, it doesn't catch cases like when calling
+//string_to_int("1.23.4") since it just reads in however much it can, without
+//realizing that there is more
+
     return i;
   }
 
@@ -179,6 +183,11 @@ namespace Utilities
                                      // check for errors
     AssertThrow (i != max_double, ExcCantConvertString (s));
 
+//TODO: The test for errors above doesn't work, as can easily be
+//verified. furthermore, it doesn't catch cases like when calling
+//string_to_int("1.23.4") since it just reads in however much it can, without
+//realizing that there is more
+
     return i;
   }
 

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.