]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Remove unused method arguments.
authorDavid Wells <wellsd2@rpi.edu>
Sat, 5 Nov 2016 14:14:31 +0000 (10:14 -0400)
committerDavid Wells <wellsd2@rpi.edu>
Sat, 5 Nov 2016 14:54:57 +0000 (10:54 -0400)
This is a protected method which is always called with two member
variables with identical names as the function arguments.

This was caught by PVS studio.

include/deal.II/lac/precondition_block.h
include/deal.II/lac/precondition_block.templates.h

index bf168e3afb90c413f259c9e8776a7fc590f58282..76eca4f6041df65c0e95593be55be1664c91f895 100644 (file)
@@ -212,8 +212,7 @@ protected:
   /**
    * Replacement of invert_diagblocks() for permuted preconditioning.
    */
-  void invert_permuted_diagblocks(const std::vector<size_type> &permutation,
-                                  const std::vector<size_type> &inverse_permutation);
+  void invert_permuted_diagblocks();
 public:
   /**
    * Deletes the inverse diagonal block matrices if existent, sets the
index f8e9f6509400e561b28dc916ce0b31759b1de860..e6ced51b0253ede2ffaca3c0e0124aad87c3d1a3 100644 (file)
@@ -93,7 +93,7 @@ void PreconditionBlock<MatrixType,inverse_type>::initialize
   if (parameters.invert_diagonal)
     {
       if (permutation.size() == M.m())
-        invert_permuted_diagblocks(permutation, inverse_permutation);
+        invert_permuted_diagblocks();
       else
         invert_diagblocks();
     }
@@ -112,9 +112,7 @@ void PreconditionBlock<MatrixType,inverse_type>::initialize
 }
 
 template <typename MatrixType, typename inverse_type>
-void PreconditionBlock<MatrixType,inverse_type>::invert_permuted_diagblocks
-(const std::vector<size_type> &permutation,
- const std::vector<size_type> &inverse_permutation)
+void PreconditionBlock<MatrixType,inverse_type>::invert_permuted_diagblocks()
 {
   Assert (A!=0, ExcNotInitialized());
   Assert (blocksize!=0, ExcNotInitialized());

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.