]> https://gitweb.dealii.org/ - dealii.git/commitdiff
resolve comments 18361/head
authorMichał Wichrowski <mtwichrowski@gmail.com>
Fri, 2 May 2025 16:40:31 +0000 (18:40 +0200)
committerMichał Wichrowski <mtwichrowski@gmail.com>
Fri, 2 May 2025 16:40:31 +0000 (18:40 +0200)
include/deal.II/lac/full_matrix.h
include/deal.II/numerics/tensor_product_matrix_creator.h

index 2f9ae851be178d2c081693e245c91a10e9e15e88..6838eaec1cc647763454665ba24dea93bd2623da 100644 (file)
@@ -984,10 +984,10 @@ public:
    * m x n matrix A and a p x q matrix B is an (m*p) x (n*q) matrix defined as:
    *
    * ```
-   * A ⊗ B = | a11*B   a12*B   ...   a1n*B   |
-   *           | a21*B   a22*B   ...   a2n*B   |
-   *           |  ...     ...     ...     ...   |
-   *           | am1*B   am2*B   ...   amn*B   |
+   * A ⊗ B = | a11*B   a12*B   ...   a1n*B |
+   *         | a21*B   a22*B   ...   a2n*B |
+   *         | ...     ...     ...   ...   |
+   *         | am1*B   am2*B   ...   amn*B |
    * ```
    *
    * where aij are the elements of the matrix A.
index 60b672eb591064ce8f85d469395e7f9020b76724..ab5159cdd441c7b8fe5299d271b96a5881614179 100644 (file)
@@ -556,7 +556,6 @@ namespace TensorProductMatrixCreator
 
     const unsigned int degree          = fe.degree;
     const unsigned int n_dofs_per_cell = fe.dofs_per_cell;
-    const Number      &JxW             = h;
     QGauss<1>          quadrature(degree + 1);
 
     FullMatrix<Number> cell_matrix(n_dofs_per_cell, n_dofs_per_cell);
@@ -573,7 +572,7 @@ namespace TensorProductMatrixCreator
           cell_matrix(i - shift, j - shift) +=
             (fe.shape_value(numbering[i], quadrature.point(q)) *
              fe.shape_value(numbering[j], quadrature.point(q))) *
-            JxW * quadrature.weight(q);
+            (h * quadrature.weight(q));
 
     return cell_matrix;
   }
@@ -620,7 +619,7 @@ namespace TensorProductMatrixCreator
           cell_matrix(i - shift, j - shift) +=
             (fe.shape_grad(numbering[i], quadrature.point(q)) / h *
              fe.shape_grad(numbering[j], quadrature.point(q))) /
-            h * JxW * quadrature.weight(q);
+            h * (h * quadrature.weight(q));
 
     return cell_matrix;
   }

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.