Add an extra iterator validation check.

Coverity complains about this, so we may as well add an extra check for
iterator correctness.

diff --git a/source/numerics/time_dependent.cc b/source/numerics/time_dependent.cc
index 257cf0bbe389d2b7605b55ed1ffd9f45ad92564a..bee615228c57779f57025c10bb5be64d06d72ea9 100644 (file)
--- a/source/numerics/time_dependent.cc
+++ b/source/numerics/time_dependent.cc
@@ -97,14 +97,18 @@ TimeDependent::insert_timestep (const TimeStepBase *position,
   else
     {
       // inner time step
-      std::vector<SmartPointer<TimeStepBase,TimeDependent> >::iterator insert_position
+      const std::vector<SmartPointer<TimeStepBase,TimeDependent> >::iterator insert_position
         = std::find(timesteps.begin(), timesteps.end(), position);
+      // check iterators again to satisfy coverity: both insert_position and
+      // insert_position - 1 must be valid iterators
+      Assert(insert_position != timesteps.begin() &&
+             insert_position != timesteps.end(), ExcInternalError());
 
       (*(insert_position-1))->set_next_timestep (new_timestep);
       new_timestep->set_previous_timestep (*(insert_position-1));
       new_timestep->set_next_timestep (*insert_position);
       (*insert_position)->set_previous_timestep (new_timestep);
-    };
+    }
 
   // finally enter it into the
   // array