]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Avoid numdiff check race condition in test 5323/head
authorTimo Heister <timo.heister@gmail.com>
Wed, 25 Oct 2017 14:07:22 +0000 (10:07 -0400)
committerTimo Heister <timo.heister@gmail.com>
Wed, 25 Oct 2017 14:07:22 +0000 (10:07 -0400)
Do not remove the test files to avoid a race condition if
cmake decides to rerun in a concurrent situation. Otherwise this would
trigger the following error:
"The detected numdiff executable was not able to pass a simple relative
tolerance test."

cmake/macros/macro_deal_ii_pickup_tests.cmake

index 1ce3748519b3a36865b44ed391362fc82ceb6c92..3284f6dc21486b89c7740709067bec5df30f2cab 100644 (file)
@@ -164,11 +164,10 @@ MACRO(DEAL_II_PICKUP_TESTS)
       RESULT_VARIABLE _numdiff_tolerance_test_status
       )
 
-    #
-    # Tidy up:
-    #
-    FILE(REMOVE ${_first_test_file_name})
-    FILE(REMOVE ${_second_test_file_name})
+    # Note: We do not remove the test files to avoid a race condition if 
+    # cmake decides to rerun in a concurrent situation:
+    # FILE(REMOVE ${_first_test_file_name})
+    # FILE(REMOVE ${_second_test_file_name})
 
     IF(NOT "${_numdiff_tolerance_test_status}" STREQUAL "0")
       MESSAGE(FATAL_ERROR

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.