Bugfix: Return a reference to *this in operator=

Wow. I missed this. Surprising that we did not get a compiler warning
for this.

This fixes tests bits/periodicity_06/07 [1, 2].

[1] That test something entirely different but luckily happen to trigger
this.

[2] https://cdash.43-1.org/testDetails.php?test=47189344&build=7349

terminate called after throwing an instance of 'std::system_error'
  what():  Operation not permitted

In reference to #10473

diff --git a/include/deal.II/base/thread_local_storage.h b/include/deal.II/base/thread_local_storage.h
index 80e47afb6397783e19eeb85c646300fcb5854cd7..cd40096a4678332db304e848b86aaf1664daa9d4 100644 (file)
--- a/include/deal.II/base/thread_local_storage.h
+++ b/include/deal.II/base/thread_local_storage.h
@@ -353,6 +353,8 @@ namespace Threads
     std::unique_lock<decltype(insertion_mutex)> writer_lock(insertion_mutex);
 
     data = std::move(t.data);
+
+    return *this;
   }