]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Drop support for p4est versions older than 2.2. 17539/head
authorDavid Wells <drwells@email.unc.edu>
Thu, 15 Aug 2024 16:03:06 +0000 (10:03 -0600)
committerDavid Wells <drwells@email.unc.edu>
Thu, 15 Aug 2024 16:03:06 +0000 (10:03 -0600)
We already have several features which depend on this version.

cmake/configure/configure_50_p4est.cmake
doc/news/changes/incompatibilities/20240815DavidWells [new file with mode: 0644]
source/distributed/tria.cc

index 13992d1d1f6e75c6b3148029726d97621a26c829..77c170d9677f73b0953a5ac4b8b5716188b1b6e7 100644 (file)
@@ -26,9 +26,9 @@ macro(feature_p4est_find_external var)
     set(${var} TRUE)
 
     #
-    # We require at least version 2.0
+    # We require at least version 2.2
     #
-    set(_version_required 2.0)
+    set(_version_required 2.2)
     if(P4EST_VERSION VERSION_LESS ${_version_required})
       message(STATUS "Insufficient p4est installation found: "
         "At least version ${_version_required} is required."
diff --git a/doc/news/changes/incompatibilities/20240815DavidWells b/doc/news/changes/incompatibilities/20240815DavidWells
new file mode 100644 (file)
index 0000000..78021f6
--- /dev/null
@@ -0,0 +1,4 @@
+Changed: The minimum version of p4est compatible with deal.II has been
+increased to 2.2.
+<br>
+(David Wells, 2024/08/15)
index 623822953dd93bddea365b047b3eb945bf0bea3f..27f27e1a53625e7f05d3f0a07c23b9f99d91cfe5 100644 (file)
@@ -618,7 +618,6 @@ namespace
       }
   }
 
-#  ifdef P4EST_SEARCH_LOCAL
   template <int dim>
   class PartitionSearch
   {
@@ -1193,7 +1192,7 @@ namespace
 
     are_vertices_initialized = true;
   }
-#  endif //  P4EST_SEARCH_LOCAL defined
+
 
 
   /**
@@ -1977,19 +1976,6 @@ namespace parallel
                             this->data_serializer.dest_sizes_variable.end(),
                             std::vector<int>::size_type(0)));
 
-#  if DEAL_II_P4EST_VERSION_GTE(2, 0, 65, 0)
-#  else
-          // ----- WORKAROUND -----
-          // An assertion in p4est prevents us from sending/receiving no data
-          // at all, which is mandatory if one of our processes does not own
-          // any quadrant. This bypasses the assertion from being triggered.
-          //   - see: https://github.com/cburstedde/p4est/issues/48
-          if (this->data_serializer.src_sizes_variable.empty())
-            this->data_serializer.src_sizes_variable.resize(1);
-          if (this->data_serializer.dest_sizes_variable.empty())
-            this->data_serializer.dest_sizes_variable.resize(1);
-#  endif
-
           // Execute variable size transfer.
           dealii::internal::p4est::functions<dim>::transfer_custom(
             parallel_forest->global_first_quadrant,
@@ -3202,16 +3188,6 @@ namespace parallel
     std::vector<types::subdomain_id> Triangulation<dim, spacedim>::
       find_point_owner_rank(const std::vector<Point<dim>> &points)
     {
-#  ifndef P4EST_SEARCH_LOCAL
-      (void)points;
-      AssertThrow(
-        false,
-        ExcMessage(
-          "This function is only available if p4est is version 2.2 and higher."));
-      // Just return to satisfy compiler
-      return std::vector<unsigned int>(1,
-                                       dealii::numbers::invalid_subdomain_id);
-#  else
       // We can only use this function if vertices are communicated to p4est
       AssertThrow(this->are_vertices_communicated_to_p4est(),
                   ExcMessage(
@@ -3298,7 +3274,6 @@ namespace parallel
       sc_array_destroy_null(&point_sc_array);
 
       return owner_rank;
-#  endif // P4EST_SEARCH_LOCAL defined
     }
 
 

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.