]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Don't pass const bool by reference
authorDaniel Arndt <daniel.arndt@iwr.uni-heidelberg.de>
Sat, 25 Aug 2018 17:41:39 +0000 (19:41 +0200)
committerDaniel Arndt <daniel.arndt@iwr.uni-heidelberg.de>
Sun, 26 Aug 2018 10:50:41 +0000 (12:50 +0200)
include/deal.II/base/parameter_handler.h
include/deal.II/sundials/ida.h
include/deal.II/sundials/kinsol.h
source/base/parameter_handler.cc
source/grid/grid_tools.cc

index 2a98bf5ca2090ea1be02182cfe9d619933f31823..2cf6b492f16579c173d04c874854a453cfd7e081 100644 (file)
@@ -1317,7 +1317,7 @@ public:
    * the new value does not conform to the pattern for this entry.
    */
   void
-  set(const std::string &entry_name, const bool &new_value);
+  set(const std::string &entry_name, const bool new_value);
 
 
   /**
index ad48bd2ec54f531ea00d761160465ba79758bf54..66de1f64617dff5a804563493a845703940d8ea6 100644 (file)
@@ -315,7 +315,7 @@ namespace SUNDIALS
         // Error parameters
         const double &absolute_tolerance                = 1e-6,
         const double &relative_tolerance                = 1e-5,
-        const bool &  ignore_algebraic_terms_for_errors = true,
+        const bool    ignore_algebraic_terms_for_errors = true,
         // Initial conditions parameters
         const InitialConditionCorrection &ic_type    = use_y_diff,
         const InitialConditionCorrection &reset_type = use_y_diff,
index 0c7dfab7c3c80f31cc473ebc827440b47793651f..16681e232a71cc7281c4a44aa7aabd8c274b1806 100644 (file)
@@ -262,7 +262,7 @@ namespace SUNDIALS
         const unsigned int      maximum_non_linear_iterations = 200,
         const double &          function_tolerance            = 0.0,
         const double &          step_tolerance                = 0.0,
-        const bool &            no_init_setup                 = false,
+        const bool              no_init_setup                 = false,
         const unsigned int      maximum_setup_calls           = 0,
         const double &          maximum_newton_step           = 0.0,
         const double &          dq_relative_error             = 0.0,
index 780d1bbe766d0899ab48c63411828abb643fe69f..54d4e4619e31528a0473d65f2d5d6675fef54174 100644 (file)
@@ -1031,7 +1031,7 @@ ParameterHandler::set(const std::string &entry_string, const long int new_value)
 
 
 void
-ParameterHandler::set(const std::string &entry_string, const bool &new_value)
+ParameterHandler::set(const std::string &entry_string, const bool new_value)
 {
   // hand this off to the function that
   // actually sets the value as a string
index 10498843ba97f1a94b6d9c8589ab8a4eee38a205..48f77b7a03fcf6497cab902ff43150dc7e6ddc18 100644 (file)
@@ -4425,7 +4425,7 @@ namespace GridTools
                      std::vector<Point<spacedim>>,
                      std::vector<unsigned int>>,
           cell_hash<dim, spacedim>> &output_unmap,
-        const bool &                 check_owned)
+        const bool                   check_owned)
       {
         bool no_check = !check_owned;
 

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.