]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Improved comment on periodicity for SphericalManifold. 2411/head
authorLuca Heltai <luca.heltai@sissa.it>
Mon, 11 Apr 2016 07:46:43 +0000 (09:46 +0200)
committerLuca Heltai <luca.heltai@sissa.it>
Mon, 11 Apr 2016 07:46:43 +0000 (09:46 +0200)
source/grid/manifold_lib.cc

index dd95f0a80cb64479431d1fc32be17f6c86fae562..4031bd58f193a2c8924896035972e80653a8d9a4 100644 (file)
@@ -36,8 +36,11 @@ Tensor<1,spacedim>
 SphericalManifold<dim,spacedim>::get_periodicity()
 {
   Tensor<1,spacedim> periodicity;
-  // In two dimensions, theta is periodic. In three dimensions the variable
-  // that is periodic is phi. We have no periodicity in theta in 3d.
+  // In two dimensions, theta is periodic.
+  // In three dimensions things are a little more complicated, since the only variable
+  // that is truly periodic is phi, while theta should be bounded between
+  // 0 and pi. There is currently no way to enforce this, so here we only fix
+  // periodicity for the last variable, corresponding to theta in 2d and phi in 3d.
   periodicity[spacedim-1] = 2*numbers::PI;
   return periodicity;
 }

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.