]> https://gitweb.dealii.org/ - dealii.git/commitdiff
When obvious, do not name unused parameters.
authorDavid Wells <drwells@vt.edu>
Sat, 4 Apr 2015 15:49:40 +0000 (11:49 -0400)
committerMatthias Maier <matthias.maier@iwr.uni-heidelberg.de>
Tue, 14 Apr 2015 10:50:18 +0000 (12:50 +0200)
Rather than writing
Triangulation<dim> &/*tria*/
where tria is a redundant name, I simply leave the unused parameter name
blank.

source/fe/fe_face.cc
source/grid/grid_generator.cc
source/grid/grid_out.cc
source/numerics/matrix_tools.cc

index 27b57ae17929dcf8d3e2213b32f7434ef9579c9d..2b8d7df436cc97db721c364cac1e57cc926c9165 100644 (file)
@@ -535,7 +535,7 @@ FE_FaceQ<1,spacedim>::fill_fe_face_values (
   const Mapping<1,spacedim> &,
   const typename Triangulation<1,spacedim>::cell_iterator &,
   const unsigned int face,
-  const Quadrature<0> &quadrature,
+  const Quadrature<0> &,
   typename Mapping<1,spacedim>::InternalDataBase &,
   typename Mapping<1,spacedim>::InternalDataBase &fedata,
   FEValuesData<1,spacedim> &data) const
index 3a5e2ef43d5958009d4ee841fb981bae4897baf6..fa5f966efbb90c048966f7570511db33d5edd3ea 100644 (file)
@@ -611,7 +611,7 @@ namespace GridGenerator
 
   template<>
   void
-  parallelogram (Triangulation<3>  &tria,
+  parallelogram (Triangulation<3>  &,
                  const Point<3>   (&/*corners*/)[3],
                  const bool         /*colorize*/)
   {
@@ -620,7 +620,7 @@ namespace GridGenerator
 
   template<>
   void
-  parallelogram (Triangulation<1>  &tria,
+  parallelogram (Triangulation<1>  &,
                  const Point<1>   (&/*corners*/)[1],
                  const bool         /*colorize*/)
   {
index ce7f07d6b751b072a61ee450cd4b25d9d0068aff..f94f424ef02cbf45238af4a74849a0b3cd5a5da3 100644 (file)
@@ -1407,7 +1407,7 @@ void GridOut::write_xfig (
 
 
 template <int dim, int spacedim>
-void GridOut::write_svg (const Triangulation<dim,spacedim> &tria,
+void GridOut::write_svg (const Triangulation<dim,spacedim> &,
                          std::ostream &/*out*/) const
 {
   Assert(false, ExcNotImplemented());
index a225524c57482e6a4b981075f62f4e25b01bef53..ba96eb5799dfba11ed175c7c4b7fbfad8a12cc5d 100644 (file)
@@ -867,7 +867,7 @@ namespace MatrixCreator
     template <int dim, int spacedim>
     void
     create_boundary_mass_matrix_1 (typename DoFHandler<dim,spacedim>::active_cell_iterator const &cell,
-                                   MatrixCreator::internal::AssemblerBoundary::Scratch const &scratch,
+                                   MatrixCreator::internal::AssemblerBoundary::Scratch const &,
                                    MatrixCreator::internal::AssemblerBoundary::CopyData<DoFHandler<dim,
                                    spacedim> > &copy_data,
                                    Mapping<dim, spacedim> const &mapping,
@@ -1135,14 +1135,13 @@ namespace MatrixCreator
 
     template <>
     void
-                                        MatrixCreator::internal::AssemblerBoundary::Scratch const
-                                        &scratch,
     create_boundary_mass_matrix_1<1,3> (DoFHandler<1,3>::active_cell_iterator const &/*cell*/,
+                                        MatrixCreator::internal::AssemblerBoundary::Scratch const &,
                                         MatrixCreator::internal::AssemblerBoundary::CopyData<DoFHandler<1,
-                                        Mapping<1,3> const &mapping,
-                                        FiniteElement<1,3> const &fe,
-                                        Quadrature<0> const &q,
                                         3> > &/*copy_data*/,
+                                        Mapping<1,3> const &,
+                                        FiniteElement<1,3> const &,
+                                        Quadrature<0> const &,
                                         FunctionMap<3>::type const &/*boundary_functions*/,
                                         Function<3> const *const /*coefficient*/,
                                         std::vector<unsigned int> const &/*component_mapping*/)
@@ -1231,7 +1230,7 @@ namespace MatrixCreator
     void
     create_hp_boundary_mass_matrix_1 (typename hp::DoFHandler<dim,spacedim>::active_cell_iterator const
                                       &cell,
-                                      MatrixCreator::internal::AssemblerBoundary::Scratch const &scratch,
+                                      MatrixCreator::internal::AssemblerBoundary::Scratch const &,
                                       MatrixCreator::internal::AssemblerBoundary
                                       ::CopyData<hp::DoFHandler<dim,spacedim> > &copy_data,
                                       hp::MappingCollection<dim,spacedim> const &mapping,
@@ -1704,7 +1703,7 @@ namespace MatrixCreator
                               const Quadrature<dim>    &q,
                               SparseMatrix<double>     &matrix,
                               const Function<spacedim> *const coefficient,
-                              const ConstraintMatrix   &constraints)
+                              const ConstraintMatrix   &)
   {
     create_laplace_matrix(StaticMappingQ1<dim,spacedim>::mapping, dof, q, matrix, coefficient);
   }
@@ -1763,7 +1762,7 @@ namespace MatrixCreator
                               const Function<spacedim>      &rhs,
                               Vector<double>           &rhs_vector,
                               const Function<spacedim> *const coefficient,
-                              const ConstraintMatrix   &constraints)
+                              const ConstraintMatrix   &)
   {
     create_laplace_matrix(StaticMappingQ1<dim,spacedim>::mapping, dof, q,
                           matrix, rhs, rhs_vector, coefficient);
@@ -1816,7 +1815,7 @@ namespace MatrixCreator
                               const hp::QCollection<dim>    &q,
                               SparseMatrix<double>     &matrix,
                               const Function<spacedim> *const coefficient,
-                              const ConstraintMatrix   &constraints)
+                              const ConstraintMatrix   &)
   {
     create_laplace_matrix(hp::StaticMappingQ1<dim,spacedim>::mapping_collection, dof, q, matrix, coefficient);
   }
@@ -1872,7 +1871,7 @@ namespace MatrixCreator
                               const Function<spacedim>      &rhs,
                               Vector<double>           &rhs_vector,
                               const Function<spacedim> *const coefficient,
-                              const ConstraintMatrix   &constraints)
+                              const ConstraintMatrix   &)
   {
     create_laplace_matrix(hp::StaticMappingQ1<dim,spacedim>::mapping_collection, dof, q,
                           matrix, rhs, rhs_vector, coefficient);

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.