]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Move contents of TODO file into .h and .cc files.
authorWolfgang Bangerth <bangerth@math.tamu.edu>
Thu, 29 Mar 2001 15:26:59 +0000 (15:26 +0000)
committerWolfgang Bangerth <bangerth@math.tamu.edu>
Thu, 29 Mar 2001 15:26:59 +0000 (15:26 +0000)
git-svn-id: https://svn.dealii.org/trunk@4334 0785d39b-7218-0410-832d-ea1e28bc413d

deal.II/base/Todo [deleted file]
deal.II/base/include/base/job_identifier.h
deal.II/base/include/base/parameter_handler.h
deal.II/base/include/base/tensor.h
deal.II/base/include/base/tensor_base.h
deal.II/base/include/base/timer.h
deal.II/base/source/exceptions.cc
deal.II/base/source/parameter_handler.cc

diff --git a/deal.II/base/Todo b/deal.II/base/Todo
deleted file mode 100644 (file)
index e5351d5..0000000
+++ /dev/null
@@ -1,38 +0,0 @@
-=================================================================
-====== Things to be done for the /base library   ================
-=================================================================
-
-Move the exceptions in the Tensor package (tensor_base.h and tensor.h)
-  back into the Tensor class, if the compiler allows to do so. Also
-  rename them back (i.e. drop the initial Tensor* from the name).
-
-
-
-Think about the determinant function in the tensor package. Is it
-  useful, can it be generalized?
-> There are only non-zero alternating real valued n-forms, so a determinant
-> exists only for Tensor<k,dim>, k even
-
-Put Tensor<1,dim>::array_size directly into the array type. At
-  present, egcs 1.1.2 chokes on that.
-
-
-Fill in docs for the timer class. Hopefully finally find a way to
-  let it measure times larger than half an hour.
-> Operating system dependence. Grrr. Guido
-
-
-Revert istrstream(p.c_str()) to istrstream(p) when possible
-  (parameter_handler.cc)
-
-
-Change <iostream> to <ostream> in grid/point.h and
-  grid/tria_iterator.h when this becomes possible.
-
-
-Document the JobIdentifier class members.
-
-
-Use numeric_limits to designate the default values of bounds
-  parameters of Patterns::Integer and Patterns::Double. This would then
-  allow to use half-open intervals as well, amoung other advantages.
index ac9e87db0b9bd1b36ba5728c09814c37cc982a72..6abc06a02e4530ec0ed6aa7269e46e7fd888171f 100644 (file)
@@ -37,6 +37,7 @@ class JobIdentifier
                                     /**
                                      * ???
                                      */
+//TODO:[GK] document this variable    
     static const char* program_id();
 
                                     /**
index 81f1a4e8f2839f3c3fe51b48d66cdef627726718..f5e3ceb9ae26fdb230a43dafdd81d7f1acf00c77 100644 (file)
 #define __deal2__parameter_handler_h
 
 
+//TODO:[WB] Use numeric_limits to designate the default values of bounds parameters
+// of Patterns::Integer and Patterns::Double. This would then allow to use half-open
+// intervals as well, among other advantages.
+
+
+
 // public classes; to be declared below
 class ParameterHandler;
 class MultipleParameterLoop;
@@ -24,9 +30,11 @@ class MultipleParameterLoop;
 #include <string>
 #include <base/exceptions.h>
 
+
 // forward declaration
 class LogStream;
 
+
 /**
  * List of possible output formats.
  */
@@ -35,6 +43,7 @@ enum OutputStyle {
 };
 
 
+
 /**
  * Declare some regexps which
  * may be used to define patterns.
index 1656ed9af21c1e2a5ef410c9ce2dfa644eafbcb1..cf4d690a08a2eb74287bdb7eb816a366ebd5c813 100644 (file)
@@ -392,6 +392,7 @@ Tensor<rank_,dim>::memory_consumption ()
     be properly accessed (haven't investigated why). If anyone has a better
     idea, realize it!
 */
+//TODO:[WB] move the exceptions back into the Tensor class, if the compiler allows to do so. Also rename them back (i.e. drop the initial Tensor* from the name)
 DeclException1 (ExcInvalidTensorIndex,
                int,
                << "Invalid tensor index " << arg1);
index de0eed9e20f15a28a54c204829d53b1bbe1ee7a1..ef65282796a4d6edd495b986625dbf046069d136 100644 (file)
@@ -19,6 +19,9 @@
 // tensor stuff, so we don't want the whole tensor package to be included
 // everytime we use a point.
 
+
+//TODO:[WB] Change <iostream> to <ostream> when that becomes available
+
 #include <base/exceptions.h>
 #include <iostream>
 #include <vector>
@@ -68,37 +71,16 @@ class Tensor<1,dim>
                                      */
     static const unsigned int rank      = 1;
 
-#if (__GNUC__==2) && (__GNUC_MINOR__ < 95)  
-                                    /**
-                                     * Unnecessary variable, only used in
-                                     * the declaration of @p{array_type}.
-                                     * This variable should be omitted,
-                                     * but egcs1.1.2 chokes on that so
-                                     * we need it presently.
-                                     */
-    static const unsigned int array_size = ((dim!=0) ? (dim) : 1);
-
                                     /**
                                      * Declare an array type which can
                                      * be used to initialize statically
                                      * an object of this type.
                                      *
-                                     * Use the same condition for @p{dim==0}
-                                     * as in the @p{TensorBase<1,dim>} class.
+                                     * Avoid warning about zero-sized
+                                     * array for @p{dim==0} by
+                                     * choosing lunatic value.
                                      */
-    typedef double array_type[array_size];
-#else
-
-                                    /**
-                                     * Declare an array type which can
-                                     * be used to initialize statically
-                                     * an object of this type.
-                                     *
-                                     * Use the same condition for @p{dim==0}
-                                     * as in the @p{TensorBase<1,dim>} class.
-                                     */
-    typedef double array_type[(dim!=0) ? dim : 1];
-#endif
+    typedef double array_type[(dim!=0) ? dim : (unsigned int)(-1)];
     
                                     /**
                                      * Constructor. Initialize all entries
@@ -262,6 +244,7 @@ class Tensor<1,dim>
                                 /**
                                  * Exception
                                  */
+//TODO:[WB] move the exceptions back into the Tensor class, if the compiler allows to do so. Also rename them back (i.e. drop the initial Tensor* from the name)
 DeclException2(ExcWrongVectorSize, int, int, << "Tensor has " << arg1
               << " entries, but vector has size " << arg2);
 DeclException1 (ExcDimTooSmall,
index b82935f93fa4adf63b4829994d3750641d2ccecc..43e2a6a5141f29cc22710ba8bf3d6e90eda57a49 100644 (file)
@@ -49,6 +49,7 @@
  *
  * @author G. Kanschat, W. Bangerth
  */
+//TODO:[?] make class work with multithreading as well. better docs.
 class Timer
 {
   public:
index ecc12b110c22ae4bd8d6d420281db72eb919a418..058b10d8ebe81453abb32e2c6132ed636e3405a3 100644 (file)
 //----------------------------  exceptions.cc  ---------------------------
 
 
+//TODO:[WB] use [io]stringstream instead of [io]strstream if they become available
+//TODO:[WB] replace s.c_str() by s when that is possible
+
+
 #include <base/exceptions.h>
 #include <string>
 #include <strstream>
index ea695925b8a74f628ab85524cbe7123bd1e3464b..8a5abf354d5cf9e390d04375de301fd01276a911 100644 (file)
@@ -12,6 +12,9 @@
 //----------------------------  parameter_handler.cc  ---------------------------
 
 
+//TODO:[WB] use [io]stringstream instead of [io]strstream if they become available
+//TODO:[WB] replace s.c_str() by s when that is possible
+
 #include <base/parameter_handler.h>
 #include <base/logstream.h>
 #include <base/memory_consumption.h>

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.