]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Do not communicate vertices automatically to p4est in debug mode.
authorMarc Fehling <mafehling.git@gmail.com>
Wed, 13 Oct 2021 20:21:09 +0000 (14:21 -0600)
committerMarc Fehling <mafehling.git@gmail.com>
Fri, 15 Oct 2021 05:33:04 +0000 (23:33 -0600)
doc/news/changes/incompatibilities/20211013Fehling [new file with mode: 0644]
include/deal.II/distributed/tria.h
source/distributed/tria.cc

diff --git a/doc/news/changes/incompatibilities/20211013Fehling b/doc/news/changes/incompatibilities/20211013Fehling
new file mode 100644 (file)
index 0000000..cf0c5e2
--- /dev/null
@@ -0,0 +1,7 @@
+Changed: For parallel::distributed::Triangulation, vertices will no longer
+be communicated automatically to p4est in debug mode. Please set the
+corresponding flag
+parallel::distributed::Triangulation::Settings::communicate_vertices_to_p4est
+while constructing your triangulation object.
+<br>
+(Marc Fehling, 2021/10/13)
index dd4f34e903b11611979b57325add715a4da2f525..24e7b8d2a57a8df8af430734c8b1c3847ab1eb09 100644 (file)
@@ -325,11 +325,10 @@ namespace parallel
          */
         no_automatic_repartitioning = 0x4,
         /**
-         * Setting this flag will communicate vertices to p4est. In debug mode,
-         * the vertices will always be communicated. This way one can
-         * use the 'find_point_owner_rank()' to find the MPI rank of the active
-         * cell that owns an arbitrary point in case all attached manifolds are
-         * flat.
+         * Setting this flag will communicate vertices to p4est. This way one
+         * can use the 'find_point_owner_rank()' to find the MPI rank of the
+         * active cell that owns an arbitrary point in case all attached
+         * manifolds are flat.
          */
         communicate_vertices_to_p4est = 0x8
       };
@@ -394,7 +393,7 @@ namespace parallel
       is_multilevel_hierarchy_constructed() const override;
 
       /**
-       * Return if vertices will be communicated to p4est in release mode.
+       * Return if vertices will be communicated to p4est.
        */
       bool
       are_vertices_communicated_to_p4est() const;
@@ -886,7 +885,9 @@ namespace parallel
       {
         default_setting                          = 0x0,
         mesh_reconstruction_after_repartitioning = 0x1,
-        construct_multigrid_hierarchy            = 0x2
+        construct_multigrid_hierarchy            = 0x2,
+        no_automatic_repartitioning              = 0x4,
+        communicate_vertices_to_p4est            = 0x8
       };
 
       /**
index e53164f288be976c69c9e54d7389fa8cc3265110..069a0d9f4464d6582c082f186109d1d720c879b0 100644 (file)
@@ -1705,14 +1705,7 @@ namespace parallel
             Triangulation<dim, spacedim>::limit_level_difference_at_vertices) :
           smooth_grid,
         false)
-#  ifdef DEBUG
-      // Always communicate vertices to p4est in debug mode
-      , settings(
-          static_cast<Settings>(settings | communicate_vertices_to_p4est))
-#  else
       , settings(settings)
-#  endif
-
       , triangulation_has_content(false)
       , connectivity(nullptr)
       , parallel_forest(nullptr)

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.