]> https://gitweb.dealii.org/ - dealii-svn.git/commitdiff
CMake: Bugfix: Strip leading and trailing whitespace from linker flags in
authormaier <maier@0785d39b-7218-0410-832d-ea1e28bc413d>
Sun, 26 Jan 2014 14:55:30 +0000 (14:55 +0000)
committermaier <maier@0785d39b-7218-0410-832d-ea1e28bc413d>
Sun, 26 Jan 2014 14:55:30 +0000 (14:55 +0000)
order to not confuse cmake-2.8.8

git-svn-id: https://svn.dealii.org/trunk@32315 0785d39b-7218-0410-832d-ea1e28bc413d

deal.II/cmake/checks/check_01_cxx_features.cmake
deal.II/cmake/setup_cached_variables.cmake
deal.II/doc/news/changes.h

index 8c8759fd7692610b4ecc1461c7b248bafd56dd00..f464702949f2bfaf69a44f46578b80a087f2ce2a 100644 (file)
@@ -254,7 +254,7 @@ IF(DEAL_II_WITH_CXX11 AND NOT DEAL_II_HAVE_CXX11)
     "or use a different compiler, instead. (If the compiler flag for C++11 "
     "support differs from \"-std=c++0x\" or \"-std=c++11\", a suitable "
     "compiler flag has to be specified manually via\n"
-    "    -DDEAL_II_CXX11_FLAG="..."\n\n"
+    "    -DDEAL_II_CXX11_FLAG=\"...\"\n\n"
     )
 ENDIF()
 
index 897d36befa43b44d17d2a89f6296c9c65b9c8afc..51a3f0bc453ea4490d4f357637a94576e39b407c 100644 (file)
@@ -304,9 +304,13 @@ ENDFOREACH()
 # Finally, read in CXXFLAGS and LDFLAGS from environment and prepend them
 # to the saved variables:
 #
-
-SET(CMAKE_CXX_FLAGS_SAVED "$ENV{CXXFLAGS} ${CMAKE_CXX_FLAGS_SAVED}")
+# Also strip leading and trailing whitespace from linker flags to make
+# old cmake versions happy
+#
+SET(DEAL_II_CXX_FLAGS_SAVED "$ENV{CXXFLAGS} ${DEAL_II_CXX_FLAGS_SAVED}")
+STRING(STRIP "${DEAL_II_CXX_FLAGS_SAVED}" DEAL_II_CXX_FLAGS_SAVED)
 SET(DEAL_II_LINKER_FLAGS_SAVED "$ENV{LDFLAGS} ${DEAL_II_LINKER_FLAGS_SAVED}")
+STRING(STRIP "${DEAL_II_LINKER_FLAGS_SAVED}" DEAL_II_LINKER_FLAGS_SAVED)
 UNSET(ENV{CXXFLAGS})
 UNSET(ENV{LDFLAGS})
 
index 4a94777bb01c0f9d09f7228a13f44a80787e2125..86aff38a9f22100284a6d82638710a9ce0e5ffba 100644 (file)
@@ -84,6 +84,12 @@ inconvenience this causes.
 <h3>Specific improvements</h3>
 
 <ol>
+  <li>Fixed: A regression where a single whitespace accidentally added to
+  DEAL_II_LINKER_FLAGS internally prevented cmake-2.8.8 from configuring
+  sucessfully
+  <br>
+  (Matthias Maier, Krysztof Bzowski 2014/01/26)
+
   <li> Changed: It was possible to call DoFAccessor::set_active_fe_index()
   on non-active cells. However, this made no sense: Since degrees of
   freedoms only exist on active cells

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.