]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Fixed WB's comments
authorLuca Heltai <luca.heltai@sissa.it>
Tue, 5 Dec 2017 14:02:33 +0000 (15:02 +0100)
committerLuca Heltai <luca.heltai@sissa.it>
Tue, 5 Dec 2017 14:20:47 +0000 (15:20 +0100)
include/deal.II/opencascade/utilities.h
source/opencascade/utilities.cc

index e51525d215356b0b08c96ca0aced0d93bc326504..8d16be67e2e4c493d024c7e380f347172af7c3fe 100644 (file)
@@ -226,14 +226,18 @@ namespace OpenCASCADE
   /**
    * Given a Triangulation and an optional Mapping, create a vector of smooth
    * curves that interpolate the connected parts of the boundary vertices of
-   * the Triangulation and return them as a vector of TopoDS_Edge.
+   * the Triangulation and return them as a vector of TopoDS_Edge objects.
+   *
+   * This function constructs closed Bspline curve objects passing through all
+   * vertices of the boundary of the triangulation, with $C^2$ Continuity on
+   * each vertex except the first, where only $C^1$ continuity is guaranteed.
    *
    * The returned curves are ordered with respect to the indices of the faces
    * that make up the triangulation boundary, i.e., the first curve is the one
    * extracted starting from the face with the lowest index, and so on.
    *
-   * @param[input] triangulation Input triangulation
-   * @param[input] mapping Optional input mapping
+   * @param[in] triangulation Input triangulation
+   * @param[in] mapping Optional input mapping
    * @return An std::vector of TopoDS_Edge objects representing the smooth
    *  interpolation of the boundary of the `triangulation`
    *
index 77429dbd427b96509592d3737bb57a6e1bc64c7a..4f99bdb80485c25e1d3c27e2bdb1645f021d6725 100644 (file)
@@ -485,8 +485,8 @@ namespace OpenCASCADE
           {
             // get global face and vertex indices
             face_index = cell->face(f)->index();
-            unsigned int v0 = cell->face(f)->vertex_index(0);
-            unsigned int v1 = cell->face(f)->vertex_index(1);
+            const unsigned int v0 = cell->face(f)->vertex_index(0);
+            const unsigned int v1 = cell->face(f)->vertex_index(1);
             face_to_verts[face_index].first  = v0;
             face_to_verts[face_index].second = v1;
             visited_faces[face_index] = false;
@@ -552,7 +552,6 @@ namespace OpenCASCADE
         while (point_index != start_point_index);
 
         interpolation_curves.push_back(interpolation_curve(pointlist, Tensor<1,3>(), true));
-        pointlist.clear();
 
         finished = true;
         for (const auto &f : visited_faces)

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.