]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Some annotations.
authorWolfgang Bangerth <bangerth@math.tamu.edu>
Thu, 8 Mar 2001 08:11:58 +0000 (08:11 +0000)
committerWolfgang Bangerth <bangerth@math.tamu.edu>
Thu, 8 Mar 2001 08:11:58 +0000 (08:11 +0000)
git-svn-id: https://svn.dealii.org/trunk@4168 0785d39b-7218-0410-832d-ea1e28bc413d

deal.II/deal.II/include/fe/mapping_q.h
deal.II/deal.II/source/fe/mapping_q.cc

index fd0f76c5b1f9f6c8656b1c4007fe21e49a258335..5c33194d566d7e5f4754ce4c22fcf36b31bec1df 100644 (file)
@@ -434,7 +434,7 @@ class MappingQ : public MappingQ1<dim>
                                      * mapping of cells at the
                                      * boundary.
                                      */
-    TensorProductPolynomials<dim>tensor_pols;
+    TensorProductPolynomials<dim> *tensor_pols;
     
                                     /**
                                      * Number of the Qp tensor
@@ -453,6 +453,7 @@ class MappingQ : public MappingQ1<dim>
                                     /**
                                      * Needed for inner faces.
                                      */
+//TODO: can we make this variable static?    
     StraightBoundary<dim> straight_boundary;
 
                                     /**
@@ -462,6 +463,7 @@ class MappingQ : public MappingQ1<dim>
                                      * Used to test the covariant
                                      * transformation.
                                      */
+//TODO: why have two ways to compute? if they both work, choose one and remove the other    
     bool alternative_normals_computation;
 
                                     /**
@@ -472,6 +474,7 @@ class MappingQ : public MappingQ1<dim>
                                      *
                                      * The default value is false.
                                      */
+//TODO: remove use_mapping_q_on_all_cells as it is set to false in the constructor and never set again    
     bool use_mapping_q_on_all_cells;
 };
 
index 04b73b163f6b038bd7233c3b123b53173c3ce742..f42fe23efb3e9036108eca72c042856b4fecfb38 100644 (file)
@@ -48,7 +48,9 @@ MappingQ<1>::MappingQ (unsigned int):
                tensor_pols(0),
                n_shape_functions(2),
                renumber(0),
+//TODO: why have two ways to compute? if they both work, choose one and remove the other    
                alternative_normals_computation(false),
+//TODO: remove use_mapping_q_on_all_cells as it is set to false in the constructor and never set again    
                use_mapping_q_on_all_cells(false)
 {}
 
@@ -61,8 +63,8 @@ MappingQ<1>::~MappingQ ()
 
 
 
-template<typename number> static
-number power(number x, unsigned int y)
+template<typename number>
+static number power(const number x, const unsigned int y)
 {
   number value=1;
   for (unsigned int i=0; i<y; ++i)
@@ -72,7 +74,7 @@ number power(number x, unsigned int y)
 
 
 template<int dim>
-MappingQ<dim>::MappingQ (unsigned int p):
+MappingQ<dim>::MappingQ (const unsigned int p):
                laplace_on_quad_vector(0),
                laplace_on_hex_vector(0),
                degree(p),
@@ -82,7 +84,9 @@ MappingQ<dim>::MappingQ (unsigned int p):
                tensor_pols(0),
                n_shape_functions(0),
                renumber(0),
+//TODO: why have two ways to compute? if they both work, choose one and remove the other    
                alternative_normals_computation(false),
+//TODO: remove use_mapping_q_on_all_cells as it is set to false in the constructor and never set again    
                use_mapping_q_on_all_cells(false)
 {
                                   // Construct the tensor product

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.