]> https://gitweb.dealii.org/ - dealii.git/commitdiff
CMake: Bugfix: only export DEAL_II_GMSH_WITH_API if gmsh is configured 14550/head
authorMatthias Maier <tamiko@43-1.org>
Thu, 8 Dec 2022 01:25:46 +0000 (19:25 -0600)
committerMatthias Maier <tamiko@43-1.org>
Thu, 8 Dec 2022 17:44:10 +0000 (11:44 -0600)
If the gmsh library is installed but the gmsh executable is missing we
currently disable gmsh support. This implies that we will not link
against the gmsh library.

Unfortunately, on first configure pass the variable `GMSH_WITH_API` is
still populated with a `TRUE` value and the `DEAL_II_GMSH_WITH_API`
variable gets set by accident and final linkage fails.

This issue is hard to spot because a second invocation of cmake will
cure the configure mistake (and the debian/ubuntu packages do not run
any autodetection).

cmake/configure/configure_50_gmsh.cmake

index 53f93ea485b08be5b0434f0e767bbc0177454225..afb6f19c9980725dd1819e9be89d5e070582d728 100644 (file)
@@ -17,5 +17,8 @@
 # Configuration for the gmsh executable:
 #
 
+macro(feature_gmsh_configure_external)
+  set(DEAL_II_GMSH_WITH_API ${GMSH_WITH_API})
+endmacro()
+
 configure_feature(GMSH)
-set(DEAL_II_GMSH_WITH_API ${GMSH_WITH_API})

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.