]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Add some description of when the last two IFs can happen in version 17/head
authorWolfgang Bangerth <bangerth@math.tamu.edu>
Wed, 23 Jul 2014 15:44:43 +0000 (10:44 -0500)
committerWolfgang Bangerth <bangerth@math.tamu.edu>
Wed, 23 Jul 2014 15:44:43 +0000 (10:44 -0500)
number recognition.

cmake/modules/FindP4EST.cmake

index 44846c7930720b6d0621a17ca1bc551aa9fda909..ae6f5fd2f40f8a7fb25b41b5044c83ea3a5fc942 100644 (file)
@@ -141,7 +141,12 @@ IF(EXISTS ${P4EST_INCLUDE_DIR}/p4est_config.h)
   #
   # We cannot rely on the fact that SUBMINOR or PATCH are defined.
   # Nevertheless, we need a full version number for our preprocessor macros
-  # to work. Therefore, set those numbers to 0 if necessary.
+  # to work. If the p4est version number is only of the form x.y instead of
+  # a.b.c.d, then the last two REGEX_REPLACE calls above will have failed
+  # because the regular expression didn't match the version string,
+  # and P4EST_VERSION_SUBMINOR and P4EST_VERSION_PATCH will either be
+  # empty or be the full version string. In those cases, set those numbers
+  # to 0 if necessary.
   #
   IF("${P4EST_VERSION_SUBMINOR}" MATCHES "^(|${P4EST_VERSION})$")
     SET(P4EST_VERSION_SUBMINOR "0")

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.