]> https://gitweb.dealii.org/ - dealii-svn.git/commitdiff
Remove DEAL_II_PATH from config.h
authormaier <maier@0785d39b-7218-0410-832d-ea1e28bc413d>
Mon, 1 Oct 2012 13:16:46 +0000 (13:16 +0000)
committermaier <maier@0785d39b-7218-0410-832d-ea1e28bc413d>
Mon, 1 Oct 2012 13:16:46 +0000 (13:16 +0000)
The benefit to be able to change the install prefix WITHOUT recompiling the
whole library far outweights supports for two obsolete features

git-svn-id: https://svn.dealii.org/branches/branch_cmake@26905 0785d39b-7218-0410-832d-ea1e28bc413d

deal.II/TODO.CMAKE
deal.II/include/deal.II/base/config.h.in
deal.II/source/base/path_search.cc
deal.II/source/lac/sparse_direct.cc

index 564a9d2285ceff420c4728bc495585e9a89eed77..822f3446d3973be7290aece4ca417acb0e1d3693 100644 (file)
@@ -40,6 +40,11 @@ Major:
 
 Minor:
 
+* Fixup the TODOs in
+    source/lac/sparse_dircect.cc
+    source/base/path_find.cc
+    source/base/function_parser.cc
+
 * Get rid of DEAL_II_PATH in config.h and in the sources.
 
 * HAVE_JN_ ?
index 314dd44a669f22a1f7c39375d83075371477c394..59c907f57c8cd1ad472bb70fd9717e1d956b9640 100644 (file)
@@ -38,9 +38,6 @@
 /* Define to the home page for this package. */
 #define DEAL_II_PACKAGE_URL "@DEAL_II_PACKAGE_URL@"
 
-/* Path to the deal.II directory */
-#define DEAL_II_PATH "@DEAL_II_PATH@"
-
 /* Major version number of deal.II */
 #define DEAL_II_MAJOR "@DEAL_II_VERSION_MAJOR@" # legacy
 #define DEAL_II_VERSION_MAJOR "@DEAL_II_VERSION_MAJOR@"
index c59d22984d2a178e48b82c2b6be442f6f5e924ac..8879e3863339b69b32e1b0814bbc3973b91013a4 100644 (file)
@@ -33,7 +33,9 @@ PathSearch::initialize_classes()
   v.push_back(empty);
   path_lists.insert(map_type(std::string("PARAMETER"), v));
 
-  v.push_back(std::string(DEAL_II_PATH "/lib/meshes/"));
+  /*
+   * TODO: reenable some sensible default paths. Maier, 2012
+   */
   path_lists.insert(map_type(std::string("MESH"), v));
 
   v.clear();
@@ -41,6 +43,10 @@ PathSearch::initialize_classes()
   v.push_back(std::string(".prm"));
   suffix_lists.insert(map_type(std::string("PARAMETER"), v));
 
+  /*
+   * TODO: "Would require linking with the deal.II libraries"? This .cc
+   * file gets compiled into the library... maier, 2012
+   */
                                    // We cannot use the GridIn class
                                    // to query the formats, since this
                                    // would require linking with the
index 243e0966a201ceffd22d32493f30f417c9de7139..1806635961804c33491826eee5edb0169b569a82 100644 (file)
@@ -519,7 +519,11 @@ SparseDirectMA27::initialize (const SparsityPattern &sp)
                                            // copy of the program, and
                                            // run the detached solver
                                            // slave instead
-          const char * const program_name = DEAL_II_PATH"/lib/bin/detached_ma27";
+          /*
+           * TODO: Does this invocation work with just the name of the
+           * executable? Maier, 2012
+           */
+          const char * const program_name = "detached_ma27";
           const char * const child_argv[] = { program_name, NULL };
           execv(program_name, const_cast<char * const *>(child_argv));
 

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.