]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Change the type of ChartManifold::sub_manifold.
authorWolfgang Bangerth <bangerth@colostate.edu>
Sat, 26 Nov 2016 03:09:45 +0000 (20:09 -0700)
committerWolfgang Bangerth <bangerth@colostate.edu>
Sat, 26 Nov 2016 03:11:32 +0000 (20:11 -0700)
include/deal.II/grid/manifold.h

index bee19b2757444dfc6f30eb9eba4f4c33eb479f0f..a1fda6dfb23c7a68afe3e7b37a6ce0fccdee1495 100644 (file)
@@ -1028,8 +1028,15 @@ private:
   /**
    * The sub_manifold object is used to compute the average of the points in
    * the chart coordinates system.
+   *
+   * In an ideal world, it would have type
+   * FlatManifold<dim,chartdim>. However, this would instantiate cases
+   * where dim>spacedim, which leads to invalid situations. We instead
+   * use <chartdim,chartdim>, which is (i) always valid, and (ii) does
+   * not matter at all since the first (dim) argument of manifolds is,
+   * in fact, ignored as far as manifold functionality is concerned.
    */
-  const FlatManifold<dim,chartdim> sub_manifold;
+  const FlatManifold<chartdim,chartdim> sub_manifold;
 };
 
 

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.