]> https://gitweb.dealii.org/ - dealii-svn.git/commitdiff
Leave a comment that this case is really treated for good.
authorbangerth <bangerth@0785d39b-7218-0410-832d-ea1e28bc413d>
Sun, 13 Aug 2006 04:28:24 +0000 (04:28 +0000)
committerbangerth <bangerth@0785d39b-7218-0410-832d-ea1e28bc413d>
Sun, 13 Aug 2006 04:28:24 +0000 (04:28 +0000)
git-svn-id: https://svn.dealii.org/trunk@13696 0785d39b-7218-0410-832d-ea1e28bc413d

deal.II/deal.II/source/dofs/dof_tools.cc

index 9812622a3079bb0234421efeccf5b563df2e5d2d..ab2ee0de45ec826d27dbdc77a987d3be1586c547 100644 (file)
@@ -2209,17 +2209,60 @@ namespace internal
                        ->get_dof_indices (dofs_on_children,
                                           subface_fe_index);
                                              
-                                                      // Now create the element
-                                                      // constraint for this subface.
-                     
-//TODO: Think about this a bit more: neighbor_child is computed correctly,
-//taking into account face_orientation. however, we don't care about this
-//here, when we ask for subface_interpolation on subface c. do we have to
-//translate things here?
-//
-//btw, this is checked in the deal.II/project_*_03 tests, that verify that the
-//approximation order of finite elements on meshes with constraints and at
-//least one face_orientation==false is as expected
+                                                      // Now create the
+                                                      // element constraint
+                                                      // for this subface.
+                                                      //
+                                                      // As a side remark,
+                                                      // one may wonder the
+                                                      // following:
+                                                      // neighbor_child is
+                                                      // clearly computed
+                                                      // correctly,
+                                                      // i.e. taking into
+                                                      // account
+                                                      // face_orientation
+                                                      // (just look at the
+                                                      // implementation of
+                                                      // that
+                                                      // function). however,
+                                                      // we don't care about
+                                                      // this here, when we
+                                                      // ask for
+                                                      // subface_interpolation
+                                                      // on subface c. the
+                                                      // question rather is:
+                                                      // do we have to
+                                                      // translate 'c' here
+                                                      // as well?
+                                                      //
+                                                      // the answer is in
+                                                      // fact 'no'. if one
+                                                      // does that, results
+                                                      // are wrong:
+                                                      // constraints are
+                                                      // added twice for the
+                                                      // same pair of nodes
+                                                      // but with differing
+                                                      // weights. in
+                                                      // addition, one can
+                                                      // look at the
+                                                      // deal.II/project_*_03
+                                                      // tests that look at
+                                                      // exactly this case:
+                                                      // there, we have a
+                                                      // mesh with at least
+                                                      // one
+                                                      // face_orientation==false
+                                                      // and hanging nodes,
+                                                      // and the results of
+                                                      // those tests show
+                                                      // that the result of
+                                                      // projection verifies
+                                                      // the approximation
+                                                      // properties of a
+                                                      // finite element onto
+                                                      // that mesh
                      face_constraints.reinit (n_dofs_on_mother,
                                               n_dofs_on_children);
                      cell->get_fe()

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.