]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Pass CellSimilarity arguments by value rather than by reference.
authorWolfgang Bangerth <bangerth@math.tamu.edu>
Mon, 20 Jul 2015 18:24:24 +0000 (13:24 -0500)
committerWolfgang Bangerth <bangerth@math.tamu.edu>
Mon, 20 Jul 2015 18:24:54 +0000 (13:24 -0500)
These are integral valued arguments for which references are not necessary. They are
also all input arguments.

16 files changed:
include/deal.II/fe/fe.h
include/deal.II/fe/fe_dgp_nonparametric.h
include/deal.II/fe/fe_face.h
include/deal.II/fe/fe_nothing.h
include/deal.II/fe/fe_poly.h
include/deal.II/fe/fe_poly.templates.h
include/deal.II/fe/fe_poly_face.h
include/deal.II/fe/fe_poly_face.templates.h
include/deal.II/fe/fe_poly_tensor.h
include/deal.II/fe/fe_system.h
source/fe/fe_dgp_nonparametric.cc
source/fe/fe_face.cc
source/fe/fe_nothing.cc
source/fe/fe_poly.cc
source/fe/fe_poly_tensor.cc
source/fe/fe_system.cc

index 2bd6306476d653424706fae7eff5b050abf8963a..3242f99b8c7b8a5a334c50246d312873ddc125dc 100644 (file)
@@ -2064,7 +2064,7 @@ protected:
                   const typename Mapping<dim,spacedim>::InternalDataBase          &mapping_internal,
                   const typename Mapping<dim,spacedim>::InternalDataBase          &fe_internal,
                   FEValuesData<dim,spacedim>                                &data,
-                  CellSimilarity::Similarity                           &cell_similarity) const = 0;
+                  const CellSimilarity::Similarity                           cell_similarity) const = 0;
 
   /**
    * Fill the fields of FEFaceValues. This function performs all the
index a9caaf9baa59306e484501028c2309ce5647581e..cbca0ffbf6ea8196be3ab6e6ed84fb328af49884 100644 (file)
@@ -539,7 +539,7 @@ protected:
                   const typename Mapping<dim,spacedim>::InternalDataBase      &mapping_internal,
                   const typename Mapping<dim,spacedim>::InternalDataBase      &fe_internal,
                   FEValuesData<dim,spacedim>                            &data,
-                  CellSimilarity::Similarity                       &cell_similarity) const;
+                  const CellSimilarity::Similarity                       cell_similarity) const;
 
   /**
    * Implementation of the same function in FiniteElement.
index 5393a420971b06da02c8a7e4c05b2476ee41e98f..b2442d7eb9d459999210fc3e1954fc4e5d4caee6 100644 (file)
@@ -250,7 +250,7 @@ protected:
                   const typename Mapping<1,spacedim>::InternalDataBase      &mapping_internal,
                   const typename Mapping<1,spacedim>::InternalDataBase      &fe_internal,
                   FEValuesData<1,spacedim>                            &data,
-                  CellSimilarity::Similarity                       &cell_similarity) const;
+                  const CellSimilarity::Similarity                       cell_similarity) const;
 
   virtual void
   fill_fe_face_values (const Mapping<1,spacedim> &mapping,
index 9081f5f22de7245e48f857a27c299c774ec11512..880d8edcf61d4c11e0e31e94efbfd6aaf348f110 100644 (file)
@@ -162,7 +162,7 @@ public:
                   const typename Mapping<dim,spacedim>::InternalDataBase &mapping_data,
                   const typename Mapping<dim,spacedim>::InternalDataBase &fedata,
                   FEValuesData<dim,spacedim> &data,
-                  CellSimilarity::Similarity &cell_similarity) const;
+                  const CellSimilarity::Similarity cell_similarity) const;
 
   /**
    * Fill the fields of FEFaceValues. This function performs all the
index 50cd7139810e0da260a4da1022b4aeb269648286..68cec5a107e95fd48194364f7b44ad75ded18f18 100644 (file)
@@ -175,7 +175,7 @@ protected:
                   const typename Mapping<dim,spacedim>::InternalDataBase      &mapping_internal,
                   const typename Mapping<dim,spacedim>::InternalDataBase      &fe_internal,
                   FEValuesData<dim,spacedim>                            &data,
-                  CellSimilarity::Similarity                       &cell_similarity) const;
+                  const CellSimilarity::Similarity                       cell_similarity) const;
 
   virtual void
   fill_fe_face_values (const Mapping<dim,spacedim> &mapping,
index 1a1e0390bf0b49447370f7dbb789ab41d2c747c4..61b6e9fb02eb628978de04911f7fbedd6418d2b9 100644 (file)
@@ -254,7 +254,7 @@ FE_Poly<POLY,dim,spacedim>::fill_fe_values
  const typename Mapping<dim,spacedim>::InternalDataBase &mapping_data,
  const typename Mapping<dim,spacedim>::InternalDataBase &fedata,
  FEValuesData<dim,spacedim>                       &data,
CellSimilarity::Similarity                  &cell_similarity) const
const CellSimilarity::Similarity                  cell_similarity) const
 {
   // convert data object to internal
   // data for this class. fails with
index c1195d795b19169b7272abe3173c96cae860ca2e..574df43afff8c5b754d5a258b0b4b7c5b412c4f5 100644 (file)
@@ -163,7 +163,7 @@ protected:
                   const typename Mapping<dim,spacedim>::InternalDataBase      &mapping_internal,
                   const typename Mapping<dim,spacedim>::InternalDataBase      &fe_internal,
                   FEValuesData<dim,spacedim>                            &data,
-                  CellSimilarity::Similarity                       &cell_similarity) const;
+                  const CellSimilarity::Similarity                       cell_similarity) const;
 
   virtual void
   fill_fe_face_values (const Mapping<dim,spacedim> &mapping,
index 1af8143aab8da455dce510558e8ca3b06d88b2a1..22fe72a67264a98d1564c7fddfcd1c8158d610c2 100644 (file)
@@ -178,7 +178,7 @@ FE_PolyFace<POLY,dim,spacedim>::fill_fe_values
  const typename Mapping<dim,spacedim>::InternalDataBase &,
  const typename Mapping<dim,spacedim>::InternalDataBase &,
  FEValuesData<dim,spacedim> &,
CellSimilarity::Similarity &) const
const CellSimilarity::Similarity ) const
 {
   // Do nothing, since we do not have
   // values in the interior
index 7444d8ea7db890dc92b65cb095f63efdf8c63eba..7922b709e63176aeae51decc599f8ff2c877ee8c 100644 (file)
@@ -188,7 +188,7 @@ protected:
                   const typename Mapping<dim,spacedim>::InternalDataBase  &mapping_internal,
                   const typename Mapping<dim,spacedim>::InternalDataBase  &fe_internal,
                   FEValuesData<dim,spacedim>                        &data,
-                  CellSimilarity::Similarity                   &cell_similarity) const;
+                  const CellSimilarity::Similarity                   cell_similarity) const;
 
   virtual void
   fill_fe_face_values (const Mapping<dim,spacedim> &mapping,
index 72f487273846ad046fb1846c1f1b266e45fb4604..6389200db595ad370a7fdcbf96aff2bc703915b8 100644 (file)
@@ -825,7 +825,7 @@ protected:
                   const typename Mapping<dim,spacedim>::InternalDataBase &mapping_data,
                   const typename Mapping<dim,spacedim>::InternalDataBase &fe_data,
                   FEValuesData<dim,spacedim>                       &data,
-                  CellSimilarity::Similarity                  &cell_similarity) const;
+                  const CellSimilarity::Similarity                  cell_similarity) const;
 
   /**
    * Implementation of the same function in FiniteElement.
index 76df29295457335cb27f9abc23b0e9b85e5d3ebf..b8bf0faaa836e3c3cbca0d91867555636928be36 100644 (file)
@@ -284,7 +284,7 @@ FE_DGPNonparametric<dim,spacedim>::fill_fe_values (
   const typename Mapping<dim,spacedim>::InternalDataBase &,
   const typename Mapping<dim,spacedim>::InternalDataBase &fe_data,
   FEValuesData<dim,spacedim> &data,
-  CellSimilarity::Similarity &/*cell_similarity*/) const
+  const CellSimilarity::Similarity /*cell_similarity*/) const
 {
   const UpdateFlags flags(fe_data.current_update_flags());
   Assert (flags & update_quadrature_points, ExcInternalError());
index a6cc2341721153a12db62c0a380a36fd1e2942e1..85b909dc1dd3be4a3741d3bb9161ce8697d03d1f 100644 (file)
@@ -524,7 +524,7 @@ FE_FaceQ<1,spacedim>::fill_fe_values
  const typename Mapping<1,spacedim>::InternalDataBase &,
  const typename Mapping<1,spacedim>::InternalDataBase &,
  FEValuesData<1,spacedim> &,
CellSimilarity::Similarity &) const
const CellSimilarity::Similarity ) const
 {
   // Do nothing, since we do not have values in the interior
 }
index 3c2a37a27267ad02e1cf9d0096a4bc43d60b9739..8ffc976137885f6aa31709792031569372971a8c 100644 (file)
@@ -123,7 +123,7 @@ fill_fe_values (const Mapping<dim,spacedim> & /*mapping*/,
                 const typename Mapping<dim,spacedim>::InternalDataBase & /*mapping_data*/,
                 const typename Mapping<dim,spacedim>::InternalDataBase & /*fedata*/,
                 FEValuesData<dim,spacedim> & /*data*/,
-                CellSimilarity::Similarity & /*cell_similarity*/) const
+                const CellSimilarity::Similarity  /*cell_similarity*/) const
 {
   // leave data fields empty
 }
index cd8880af0d6387b600bf97d4011610720556db49..cf31ba690fe9294fdfdf73a3ba7d8d47516bcf75 100644 (file)
@@ -36,7 +36,7 @@ FE_Poly<TensorProductPolynomials<1>,1,2>::fill_fe_values
  const Mapping<1,2>::InternalDataBase            &mapping_data,
  const Mapping<1,2>::InternalDataBase            &fedata,
  FEValuesData<1,2>                         &data,
CellSimilarity::Similarity           &cell_similarity) const
const CellSimilarity::Similarity           cell_similarity) const
 {
   // convert data object to internal
   // data for this class. fails with
@@ -74,7 +74,7 @@ FE_Poly<TensorProductPolynomials<2>,2,3>::fill_fe_values
  const Mapping<2,3>::InternalDataBase          &mapping_data,
  const Mapping<2,3>::InternalDataBase          &fedata,
  FEValuesData<2,3>                       &data,
CellSimilarity::Similarity         &cell_similarity) const
const CellSimilarity::Similarity         cell_similarity) const
 {
 
   // assert that the following dynamics
@@ -110,7 +110,7 @@ FE_Poly<PolynomialSpace<1>,1,2>::fill_fe_values (
   const Mapping<1,2>::InternalDataBase          &mapping_data,
   const Mapping<1,2>::InternalDataBase          &fedata,
   FEValuesData<1,2>                       &data,
-  CellSimilarity::Similarity         &cell_similarity) const
+  const CellSimilarity::Similarity         cell_similarity) const
 {
   // convert data object to internal
   // data for this class. fails with
@@ -148,7 +148,7 @@ FE_Poly<PolynomialSpace<2>,2,3>::fill_fe_values
  const Mapping<2,3>::InternalDataBase          &mapping_data,
  const Mapping<2,3>::InternalDataBase          &fedata,
  FEValuesData<2,3>                       &data,
CellSimilarity::Similarity         &cell_similarity) const
const CellSimilarity::Similarity         cell_similarity) const
 {
   Assert (dynamic_cast<const InternalData *> (&fedata) != 0, ExcInternalError());
   const InternalData &fe_data = static_cast<const InternalData &> (fedata);
index 891f249094e4793239db6380d94e914fdb0f5e97..99cb7a2fc735a6d3161bf4fadfcf75a238366cde 100644 (file)
@@ -396,7 +396,7 @@ FE_PolyTensor<POLY,dim,spacedim>::fill_fe_values (
   const typename Mapping<dim,spacedim>::InternalDataBase &mapping_data,
   const typename Mapping<dim,spacedim>::InternalDataBase &fedata,
   FEValuesData<dim,spacedim>                       &data,
-  CellSimilarity::Similarity                  &cell_similarity) const
+  const CellSimilarity::Similarity                  cell_similarity) const
 {
   // convert data object to internal
   // data for this class. fails with
index fcf4b88a10a533d9f6f755faead3543d14093d66..0583588a0ef7a41217422c544c8c8a9a4269854b 100644 (file)
@@ -1040,7 +1040,7 @@ FESystem<dim,spacedim>::fill_fe_values (
   const typename Mapping<dim,spacedim>::InternalDataBase &mapping_data,
   const typename Mapping<dim,spacedim>::InternalDataBase &fe_data,
   FEValuesData<dim,spacedim>                       &data,
-  CellSimilarity::Similarity                  &cell_similarity) const
+  const CellSimilarity::Similarity                  cell_similarity) const
 {
   compute_fill(mapping, cell, invalid_face_number, invalid_face_number,
                quadrature, cell_similarity, mapping_data, fe_data, data);

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.