cppcheck: clean up use of references.

Capture by reference when the return type is by reference: capture by value when
the return type is by value.

diff --git a/include/deal.II/base/timer.h b/include/deal.II/base/timer.h
index 0873c3f95a03664a731b908059e60e2fb018478b..88149f0cff6c908ff12e8ae6802071feec0173b1 100644 (file)
--- a/include/deal.II/base/timer.h
+++ b/include/deal.II/base/timer.h
@@ -947,7 +947,7 @@ template <class StreamType>
 inline void
 Timer::print_accumulated_wall_time_data(StreamType &stream) const
 {
-  const Utilities::MPI::MinMaxAvg statistic = get_accumulated_wall_time_data();
+  const Utilities::MPI::MinMaxAvg &statistic = get_accumulated_wall_time_data();
   stream << statistic.max << " wall,"
          << " max @" << statistic.max_index << ", min=" << statistic.min << " @"
          << statistic.min_index << ", avg=" << statistic.avg << std::endl;

diff --git a/include/deal.II/base/utilities.h b/include/deal.II/base/utilities.h
index e9541a50b5e8a5e1c43e2061d632ffddebd0d3aa..f83995c14fed45f5bcdb46a855ecd80f2f38fc21 100644 (file)
--- a/include/deal.II/base/utilities.h
+++ b/include/deal.II/base/utilities.h
@@ -1264,7 +1264,7 @@ namespace Utilities
             boost::archive::binary_oarchive archive(out);
             archive << object;
 
-            const std::string &s = out.str();
+            const std::string s = out.str();
             dest_buffer.reserve(dest_buffer.size() + s.size());
             std::move(s.begin(), s.end(), std::back_inserter(dest_buffer));
           }