]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Remove (void) etc. casts for AssertNothrow() variables. 18496/head
authorDavid Wells <drwells@email.unc.edu>
Fri, 23 May 2025 19:09:14 +0000 (15:09 -0400)
committerDavid Wells <drwells@email.unc.edu>
Fri, 23 May 2025 19:09:14 +0000 (15:09 -0400)
These shouldn't be needed now.

include/deal.II/base/hdf5.h
source/base/hdf5.cc
source/base/init_finalize.cc
source/base/mpi.cc
source/lac/petsc_matrix_base.cc
source/lac/petsc_parallel_block_sparse_matrix.cc
source/lac/petsc_parallel_sparse_matrix.cc
source/lac/petsc_vector_base.cc
source/lac/slepc_solver.cc
source/lac/slepc_spectral_transformation.cc

index 50aa7fa5a2010c0d695956cb6383592ea34e2c02..3d18f882f2f1331ae3c41d6a424f440dab024eea 100644 (file)
@@ -1310,7 +1310,6 @@ namespace HDF5
               // Release the HDF5 resource
               const herr_t ret = H5Tclose(*pointer);
               AssertNothrow(ret >= 0, ExcInternalError());
-              (void)ret;
               delete pointer;
             });
 
@@ -1333,7 +1332,6 @@ namespace HDF5
               // Release the HDF5 resource
               const herr_t ret = H5Tclose(*pointer);
               AssertNothrow(ret >= 0, ExcInternalError());
-              (void)ret;
               delete pointer;
             });
           *t_type = H5Tcreate(H5T_COMPOUND, sizeof(std::complex<double>));
index a95ef9e41064bd91cd0c6373d7d8cd4bbf75b26b..b825130c1e8beda019e82b154f8f1fca28fd0271 100644 (file)
@@ -95,7 +95,6 @@ namespace HDF5
       // Release the HDF5 resource
       const herr_t ret = H5Dclose(*pointer);
       AssertNothrow(ret >= 0, ExcInternalError());
-      (void)ret;
       delete pointer;
     });
     dataspace      = std::shared_ptr<hid_t>(new hid_t, [](hid_t *pointer) {
@@ -104,7 +103,6 @@ namespace HDF5
       // Release the HDF5 resource
       const herr_t ret = H5Sclose(*pointer);
       AssertNothrow(ret >= 0, ExcInternalError());
-      (void)ret;
       delete pointer;
     });
 
@@ -154,7 +152,6 @@ namespace HDF5
       // Release the HDF5 resource
       const herr_t ret = H5Dclose(*pointer);
       AssertNothrow(ret >= 0, ExcInternalError());
-      (void)ret;
       delete pointer;
     });
     dataspace      = std::shared_ptr<hid_t>(new hid_t, [](hid_t *pointer) {
@@ -163,7 +160,6 @@ namespace HDF5
       // Release the HDF5 resource
       const herr_t ret = H5Sclose(*pointer);
       AssertNothrow(ret >= 0, ExcInternalError());
-      (void)ret;
       delete pointer;
     });
 
@@ -331,7 +327,6 @@ namespace HDF5
       // Release the HDF5 resource
       const herr_t ret = H5Gclose(*pointer);
       AssertNothrow(ret >= 0, ExcInternalError());
-      (void)ret;
       delete pointer;
     });
     switch (mode)
@@ -420,7 +415,6 @@ namespace HDF5
       // Release the HDF5 resource
       const herr_t err = H5Fclose(*pointer);
       AssertNothrow(err >= 0, ExcInternalError());
-      (void)err;
       delete pointer;
     });
 
index 9d95b6fa59ad5fa9058a09f09b9ba86e7db2e4f9..d52369441ae5637f07dcaa096c5c42667bc765d6 100644 (file)
@@ -427,8 +427,7 @@ InitFinalize::finalize()
             }
           else
             {
-              [[maybe_unused]] const int ierr = MPI_Finalize();
-
+              const int ierr = MPI_Finalize();
               AssertNothrow(ierr == MPI_SUCCESS, dealii::ExcMPI(ierr));
             }
         }
index f3cc845fe1d93cb6ccdd6ded491a0c0fcf148b6f..9606215d30e10a84b950ad2fff7b85b970c7ccc8 100644 (file)
@@ -241,10 +241,8 @@ namespace Utilities
       auto deleter = [](MPI_Datatype *p) {
         if (p != nullptr)
           {
-            [[maybe_unused]] const int ierr = MPI_Type_free(p);
-
+            const int ierr = MPI_Type_free(p);
             AssertNothrow(ierr == MPI_SUCCESS, ExcMPI(ierr));
-
             delete p;
           }
       };
index da5ea634d35b5c50ad91d9fc97ce99292e2585fc..82bfdbbb9e538a0c315ae06a0e496247909a8f18 100644 (file)
@@ -112,7 +112,6 @@ namespace PETScWrappers
   MatrixBase::~MatrixBase()
   {
     PetscErrorCode ierr = MatDestroy(&matrix);
-    (void)ierr;
     AssertNothrow(ierr == 0, ExcPETScError(ierr));
   }
 
index 8f35e8590a368335f09bddbee8550ed2baca369b..2d2afcf8de300d0f424ee499ce3966733ff9803b 100644 (file)
@@ -79,7 +79,6 @@ namespace PETScWrappers
     BlockSparseMatrix::~BlockSparseMatrix()
     {
       PetscErrorCode ierr = MatDestroy(&petsc_nest_matrix);
-      (void)ierr;
       AssertNothrow(ierr == 0, ExcPETScError(ierr));
     }
 
index 40c361ab49bb7904d5242490b0d0576919f5b714..bfdef42de97992aa928f8d4ac2093dc55bcadd1b 100644 (file)
@@ -48,7 +48,6 @@ namespace PETScWrappers
     SparseMatrix::~SparseMatrix()
     {
       PetscErrorCode ierr = MatDestroy(&matrix);
-      (void)ierr;
       AssertNothrow(ierr == 0, ExcPETScError(ierr));
     }
 
index a21266ac3406c75c59f945749b7ccff779e6e882..cf84b58d2339cbfbbcd1a2d9e9ad985b34008da7 100644 (file)
@@ -149,7 +149,6 @@ namespace PETScWrappers
     const PetscErrorCode ierr =
       PetscObjectReference(reinterpret_cast<PetscObject>(vector));
     AssertNothrow(ierr == 0, ExcPETScError(ierr));
-    (void)ierr;
     this->determine_ghost_indices();
   }
 
@@ -159,7 +158,6 @@ namespace PETScWrappers
   {
     const PetscErrorCode ierr = VecDestroy(&vector);
     AssertNothrow(ierr == 0, ExcPETScError(ierr));
-    (void)ierr;
   }
 
 
index df76220b5bb3ee4c2f44c21fc69935a22a8a9cc2..b0db9bc67dfad61f8997ed76de2198ce7b125ed9 100644 (file)
@@ -64,8 +64,6 @@ namespace SLEPcWrappers
       {
         // Destroy the solver object.
         const PetscErrorCode ierr = EPSDestroy(&eps);
-
-        (void)ierr;
         AssertNothrow(ierr == 0, ExcSLEPcError(ierr));
       }
   }
index a6f1045e6024bf23f55e0aef179863c8ae6b959e..a2cec022dc7c28a4e8e487b20df4b5c46035e73c 100644 (file)
@@ -39,7 +39,6 @@ namespace SLEPcWrappers
     if (st != nullptr)
       {
         const PetscErrorCode ierr = STDestroy(&st);
-        (void)ierr;
         AssertNothrow(ierr == 0, SolverBase::ExcSLEPcError(ierr));
       }
   }

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.