]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Apply suggestions from code review
authorDaniel Arndt <arndtd@ornl.gov>
Fri, 18 Oct 2019 14:53:26 +0000 (10:53 -0400)
committerDaniel Arndt <arndtd@ornl.gov>
Fri, 18 Oct 2019 14:57:45 +0000 (10:57 -0400)
Co-Authored-By: Wolfgang Bangerth <bangerth@colostate.edu>
examples/step-13/step-13.cc
examples/step-14/step-14.cc
examples/step-32/step-32.cc

index c80a6ca6ebb2c66f6cc41540f9699b57636cae19..688d598e7175e80cc569bcf348ed49dcc3612ced 100644 (file)
@@ -797,7 +797,7 @@ namespace Step13
       // capture default or to list all the variables that are to be bound to
       // the lambda explicitly. For the sake of clarity we decided to omit
       // the capture default here, but that capture list could equally well be
-      // `[&]` meaning that all used variables are copied into the lambda by
+      // `[&]`, meaning that all used variables are copied into the lambda by
       // reference.
       //
       // At this point, we have assembled the matrix and condensed
index 08a9f07a0717d76dd09eb33c319c851e7789873d..4f73f70132f1a586b6b2d2034c6c384f720f01c5 100644 (file)
@@ -2201,7 +2201,8 @@ namespace Step14
           cell, scratch_data, copy_data, error_indicators, face_integrals);
       };
 
-      auto copier = std::function<void(const WeightedResidualCopyData &)>();
+      auto do_nothing_copier =
+        std::function<void(const WeightedResidualCopyData &)>();
 
       // Then hand it all off to WorkStream::run() to compute the
       // estimators for all cells in parallel:
@@ -2209,7 +2210,7 @@ namespace Step14
         DualSolver<dim>::dof_handler.begin_active(),
         DualSolver<dim>::dof_handler.end(),
         worker,
-        copier,
+        do_nothing_copier,
         WeightedResidualScratchData(*DualSolver<dim>::fe,
                                     *DualSolver<dim>::quadrature,
                                     *DualSolver<dim>::face_quadrature,
index 42ad54437bcb0b44052b65a1ec841e93eb970058..9f402a376989f270b032a91040ec506b654c1839 100644 (file)
@@ -2728,7 +2728,7 @@ namespace Step32
                                              data);
       };
 
-    auto copier = [=](const Assembly::CopyData::TemperatureRHS<dim> &data) {
+    auto copier = [this](const Assembly::CopyData::TemperatureRHS<dim> &data) {
       this->copy_local_to_global_temperature_rhs(data);
     };
 

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.