]> https://gitweb.dealii.org/ - dealii.git/commitdiff
QA: clean up some comments and constants. 16780/head
authorDavid Wells <drwells@email.unc.edu>
Mon, 25 Mar 2024 12:27:10 +0000 (08:27 -0400)
committerDavid Wells <drwells@email.unc.edu>
Mon, 25 Mar 2024 14:08:38 +0000 (10:08 -0400)
None of these are technically wrong but we need to replace 0u by the explicit
reversed line orientation so that 0u can become the default later.

tests/dofs/dof_tools_21.cc
tests/dofs/dof_tools_21_b.cc
tests/dofs/dof_tools_21_b_x.cc
tests/dofs/dof_tools_21_b_x_q3.cc
tests/dofs/dof_tools_21_b_y.cc
tests/dofs/dof_tools_21_c.cc
tests/dofs/dof_tools_23.cc
tests/dofs/dof_tools_periodic.h

index fec68a306bc56bc412ca66455f39e3df636ec08a..7c8d4b14dffcfcbe7e55b12751a3825e30d7562a 100644 (file)
 
 // A simple test for
 //   DoFTools::
-//   make_periodicity_constraints (const FaceIterator       &,
-//                                 const FaceIterator       &,
-//                                 dealii::AffineConstraints<double> &,
-//                                 const std::vector<bool>  &)
+//   make_periodicity_constraints(const FaceIterator        &,
+//                                const FaceIterator        &,
+//                                AffineConstraints<double> &)
 //
 // We project an already periodic function onto the FE space of
 // periodic functions and store the resulting L2 difference
index 03d1928332b83ab5fb8dfa01fb4d931b25a057d7..5692cf3b6886bd9e6fc5832bf9fa327fc581379d 100644 (file)
 //
 // Test
 //   DoFTools::
-//   make_periodicity_constraints(const FaceIterator       &,
-//                                const FaceIterator       &,
-//                                dealii::AffineConstraints<double> &,
-//                                const std::vector<bool>  &,
+//   make_periodicity_constraints(const FaceIterator        &,
+//                                const FaceIterator        &,
+//                                AffineConstraints<double> &,
+//                                const ComponentMask       &,
 //                                unsigned char)
 // for correct behavior on non standard oriented meshes.
 //
@@ -237,7 +237,7 @@ generate_grid(Triangulation<3> &triangulation, int orientation)
 
 /*
  * Print out all face DoFs and support points as well as the actual
- * matching via make_periodicity_constraints
+ * matching via make_periodicity_constraints()
  */
 template <int dim, int spacedim>
 void
index 228a524c86506ba78d561cafeb45a140a507ee41..06335a5134e90d5e504ea853d1937730ba091f23 100644 (file)
 //
 // Test
 //   DoFTools::
-//   make_periodicity_constraints (const FaceIterator       &,
-//                                 const FaceIterator       &,
-//                                 dealii::AffineConstraints<double> &,
-//                                 const std::vector<bool>  &,
-//                                 bool, bool, bool)
+//   make_periodicity_constraints(const FaceIterator        &,
+//                                const FaceIterator        &,
+//                                AffineConstraints<double> &,
+//                                const ComponentMask       &,
+//                                unsigned char)
 // for correct behavior on non standard oriented meshes.
 //
 // a redux of why the 21_b test failed starting in r29525. in essence,
@@ -157,7 +157,7 @@ generate_grid(Triangulation<2, 3> &triangulation)
 
 /*
  * Print out all face DoFs and support points as well as the actual
- * matching via make_periodicity_constraints
+ * matching via make_periodicity_constraints()
  */
 template <int dim, int spacedim>
 void
@@ -196,7 +196,11 @@ print_matching(DoFHandler<dim, spacedim> &dof_handler)
             << std::endl;
 
   DoFTools::make_periodicity_constraints(
-    face_1, face_2, constraint_matrix, ComponentMask(), 0u);
+    face_1,
+    face_2,
+    constraint_matrix,
+    ComponentMask(),
+    ReferenceCell::reversed_combined_line_orientation());
   constraint_matrix.print(deallog.get_file_stream());
   constraint_matrix.close();
   deallog << "Matching:" << std::endl;
index 245a2bcc2817659f0640ec92dc2a2f3fd6f3ba9b..7ced410c811456bb91cb00281c21c5bf5ff3d128 100644 (file)
 //
 // Test
 //   DoFTools::
-//   make_periodicity_constraints (const FaceIterator       &,
-//                                 const FaceIterator       &,
-//                                 dealii::AffineConstraints<double> &,
-//                                 const std::vector<bool>  &,
-//                                 bool, bool, bool)
+//   make_periodicity_constraints(const FaceIterator        &,
+//                                const FaceIterator        &,
+//                                AffineConstraints<double> &,
+//                                const ComponentMask       &,
+//                                unsigned char)
 // for correct behavior on non standard oriented meshes.
 //
 // like _21_b_x but use a Q3 element. For this, the face_flip has a
@@ -191,7 +191,7 @@ generate_grid(Triangulation<2, 3> &triangulation)
 
 /*
  * Print out all face DoFs and support points as well as the actual
- * matching via make_periodicity_constraints
+ * matching via make_periodicity_constraints()
  */
 template <int dim, int spacedim>
 void
@@ -230,7 +230,11 @@ print_matching(DoFHandler<dim, spacedim> &dof_handler)
             << std::endl;
 
   DoFTools::make_periodicity_constraints(
-    face_1, face_2, constraint_matrix, ComponentMask(), 0u);
+    face_1,
+    face_2,
+    constraint_matrix,
+    ComponentMask(),
+    ReferenceCell::reversed_combined_line_orientation());
   constraint_matrix.print(deallog.get_file_stream());
   constraint_matrix.close();
   deallog << "Matching:" << std::endl;
index 17630516834b2f8dd525fb00a3c390b71f1d37a3..d01e264cd9311f0437783171a289428d68a95ecc 100644 (file)
 //
 // Test
 //   DoFTools::
-//   make_periodicity_constraints (const FaceIterator       &,
-//                                 const FaceIterator       &,
-//                                 dealii::AffineConstraints<double> &,
-//                                 const std::vector<bool>  &,
-//                                 bool, bool, bool)
+//   make_periodicity_constraints(const FaceIterator        &,
+//                                const FaceIterator        &,
+//                                AffineConstraints<double> &,
+//                                const ComponentMask       &,
+//                                unsigned char)
 // for correct behavior on non standard oriented meshes.
 //
 // like _21_b_x, but with a once refined mesh
@@ -157,7 +157,7 @@ generate_grid(Triangulation<2, 3> &triangulation)
 
 /*
  * Print out all face DoFs and support points as well as the actual
- * matching via make_periodicity_constraints
+ * matching via make_periodicity_constraints()
  */
 template <int dim, int spacedim>
 void
index 3cee6d118e0113e0e9a3609bdfdabba3028a52f9..244219b23e29ffcf3ceba2b1c79d058f9f26a7de 100644 (file)
 //
 // Test
 //   DoFTools::
-//   make_periodicity_constraints(const FaceIterator       &,
-//                                const FaceIterator       &,
-//                                dealii::AffineConstraints<double> &,
-//                                const std::vector<bool>  &,
+//   make_periodicity_constraints(const FaceIterator        &,
+//                                const FaceIterator        &,
+//                                AffineConstraints<double> &,
+//                                const ComponentMask       &,
 //                                unsigned char)
 //
 // for correct behavior with hanging nodes. This is done by additionally
@@ -243,7 +243,7 @@ generate_grid(Triangulation<3> &triangulation, int orientation)
 
 /*
  * Print out all face DoFs and support points as well as the actual
- * matching via make_periodicity_constraints
+ * matching via make_periodicity_constraints()
  */
 template <int dim, int spacedim>
 void
index bd3bd1d5760cb78c6b777382ea5c678ced2ba628..db1742fd9daa0a00b05af726757cb758e774a740 100644 (file)
 
 // A simple test for
 //   DoFTools::
-//   make_periodicity_constraints (const FaceIterator       &,
-//                                 const FaceIterator       &,
-//                                 dealii::AffineConstraints<double> &,
-//                                 const std::vector<bool>  &)
+//   make_periodicity_constraints(const FaceIterator       &,
+//                                const FaceIterator       &,
+//                                AffineConstraints<std::complex<double>> &)
 //
 // We project an already periodic function onto the FE space of
 // periodic functions and store the resulting L2 difference
index acd91dbd6958bcf7791723fbd9854de2ac8cf987..1cd22f04c00a3d088e33c5458592d6d64e9d467e 100644 (file)
@@ -15,7 +15,7 @@
 
 // Code duplication:
 // This is a copy of dof_tools_common.h with a slightly different mesh
-// generation to fit the assumptions made by make_periodicity_constraints
+// generation to fit the assumptions made by make_periodicity_constraints()
 
 #include <deal.II/base/logstream.h>
 

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.