]> https://gitweb.dealii.org/ - dealii.git/commitdiff
corrected comments
authornivesh <nidhinivesh.d@gmail.com>
Fri, 8 Jun 2018 07:23:54 +0000 (09:23 +0200)
committernivesh <nidhinivesh.d@gmail.com>
Wed, 20 Jun 2018 18:34:25 +0000 (20:34 +0200)
source/fe/fe_enriched.cc

index 783cacd54e58e8a1b2a4d4c280b231873ee82e26..a6cf40b868f0350cb3720b86317ef197b083cca0 100644 (file)
@@ -1246,28 +1246,33 @@ namespace ColorEnriched
 
 
       /*
-       * Treat interface between enriched cells specially
-       * Since the function
-       * hp::FECollection< dim, spacedim >::find_least_face_dominating_fe
-       * sometimes incorrectly returns the first element, i.e
-       * enriched FE consisting of only FE_Nothing, of fe_collection.
+       * Treat interface between enriched cells specially,
+       * until #1496 (https://github.com/dealii/dealii/issues/1496) is resolved.
+       * Each time we build constraints at the
+       * interface between two different FE_Enriched, we look for the least
+       * dominating FE via
+       * hp::FECollection< dim, spacedim >::find_least_face_dominating_fe().
+       * If we don't take further actions, we may find a dominating FE that
+       * is too restrictive, i.e. enriched FE consisting of only FE_Nothing.
        * New elements needs to be added to FECollection object to help
        * find the correct enriched FE element underlying the spaces in the
-       * adjacent cells. This is automatically done by creating appropriate
-       * new set in fe_sets.
+       * adjacent cells. This is done by creating an appropriate
+       * set in fe_sets and a call to the function
+       * make_fe_collection_from_colored_enrichments at a later stage.
        *
        * Consider a domain with three predicates and hence with three different
        * enrichment functions. Let the enriched finite element of a cell with
        * enrichment functions 1 and 2 be represented by [1 1 0], with the last
        * entry as zero since the 3rd enrichment function is not relevant for
        * the cell. If the interface has enriched FE [1 0 1] and [0 1 1]
-       * on adjacent cells, the an enriched FE [0 0 1] should exist and is
+       * on adjacent cells, an enriched FE [0 0 1] should exist and is
        * found as the dominating finite element for the two cells by
        * DoFTools::make_hanging_node_constraints using a call to the function
        * hp::FECollection::find_least_face_dominating_fe.
        * Denoting the fe set in adjacent cells as {1,3} and {2,3}, this
        * implies that an fe set {3} needs to be added! Based on the
-       * predicate configuration, this may not be automatically done.
+       * predicate configuration, this may not be automatically done without
+       * the following special treatment.
        */
 
       // loop through faces

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.