]> https://gitweb.dealii.org/ - dealii-svn.git/commitdiff
Add a 'bugfix'
authormaier <maier@0785d39b-7218-0410-832d-ea1e28bc413d>
Thu, 27 Sep 2012 12:49:51 +0000 (12:49 +0000)
committermaier <maier@0785d39b-7218-0410-832d-ea1e28bc413d>
Thu, 27 Sep 2012 12:49:51 +0000 (12:49 +0000)
git-svn-id: https://svn.dealii.org/branches/branch_cmake@26782 0785d39b-7218-0410-832d-ea1e28bc413d

deal.II/cmake/modules/FindPETSC.cmake
deal.II/cmake/modules/FindTRILINOS.cmake

index 3ba5f890596598f3b21ae0f146ca7ccc7b5f715e..05d5a37da2cd1b6a4ad83c85a6428d207ee72399 100644 (file)
@@ -20,6 +20,25 @@ INCLUDE(FindPackageHandleStandardArgs)
 SET_IF_EMPTY(PETSC_DIR "$ENV{PETSC_DIR}")
 SET_IF_EMPTY(PETSC_ARCH "$ENV{PETSC_ARCH}")
 
+#
+# So, well, yes. I'd like to include the PETScConfig.cmake file via
+# FIND_PACKAGE(), but it is broken beyond belief:
+#
+# - In source, i.e. PETSC_DIR/PETSC_ARCH, it sets BUILD_SHARED_LIBS.
+# - It does not contain its very own version number
+# - It does not contain its very own library location(s) or name(s)
+# - It does not contain necessary includes
+#
+# - It writes a lot of FIND_LIBRARY(..) statements. Seriously. What the
+#   heck? If its not the same library you're linking against, you cannot
+#   assume to be API compatible, so why not just give a list of libraries?
+#
+
+#
+# TODO: We'll have to guess which external libraries we'll have to link
+# against someday...
+#
+
 #
 # Search for the first part of the includes:
 #
@@ -31,7 +50,6 @@ FIND_PATH(PETSC_INCLUDE_DIR_ARCH petscconf.h
   PATH_SUFFIXES petsc
 )
 
-
 FIND_LIBRARY(PETSC_LIBRARIES
   NAMES petsc
   HINTS
index d2024987cf68275f05e5624877121d2dff1ab1b1..a004fac8cb8277bd777a3cc8de19d55ec87574e1 100644 (file)
@@ -19,7 +19,7 @@ SET_IF_EMPTY(TRILINOS_DIR "$ENV{TRILINOS_DIR}")
 #
 # Include the trilinos package configuration:
 #
-find_package(TRILINOS
+FIND_PACKAGE(TRILINOS
   QUIET CONFIG
   NAMES Trilinos TRILINOS
   HINTS

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.