]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Bugfix: Do not populate DEAL_II_LIBRARIES* variables
authorMatthias Maier <tamiko@43-1.org>
Mon, 22 May 2023 19:00:54 +0000 (14:00 -0500)
committerMatthias Maier <tamiko@43-1.org>
Mon, 22 May 2023 21:31:53 +0000 (16:31 -0500)
We now record dependencies with interface targets. Thus, populating
these variables with redundant libraries is incorrect.

cmake/macros/macro_define_interface_target.cmake

index 9569c79447f9425b8b6f46c8274eee8f4dca2c02..85ff8da600b37c684391b55a5edf0438f03a223d 100644 (file)
@@ -142,16 +142,12 @@ function(define_interface_target _feature)
 
     if(${_feature}_SPLIT_CONFIGURATION)
       # Future FIXME: change to block(PARENT_SCOPE)/endblock() (CMake 3.25)
-      list(APPEND DEAL_II_TARGETS_${_build} "${_interface_target}")
+      list(APPEND DEAL_II_TARGETS_${_build} ${_interface_target})
       set(DEAL_II_TARGETS_${_build} ${DEAL_II_TARGETS_${_build}} PARENT_SCOPE)
-      list(APPEND DEAL_II_LIBRARIES_${_build} "${_libraries}")
-      set(DEAL_II_LIBRARIES_${build} ${DEAL_II_LIBRARIES_${build}} PARENT_SCOPE)
     else()
       # Future FIXME: change to block(PARENT_SCOPE)/endblock() (CMake 3.25)
-      list(APPEND DEAL_II_TARGETS "${_interface_target}")
+      list(APPEND DEAL_II_TARGETS ${_interface_target})
       set(DEAL_II_TARGETS ${DEAL_II_TARGETS} PARENT_SCOPE)
-      list(APPEND DEAL_II_LIBRARIES "${_libraries}")
-      set(DEAL_II_LIBRARIES ${DEAL_II_LIBRARIES} PARENT_SCOPE)
     endif()
 
   endforeach()

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.