]> https://gitweb.dealii.org/ - dealii-svn.git/commitdiff
Add TODOs.
authorbangerth <bangerth@0785d39b-7218-0410-832d-ea1e28bc413d>
Mon, 31 Jul 2006 22:39:34 +0000 (22:39 +0000)
committerbangerth <bangerth@0785d39b-7218-0410-832d-ea1e28bc413d>
Mon, 31 Jul 2006 22:39:34 +0000 (22:39 +0000)
git-svn-id: https://svn.dealii.org/trunk@13560 0785d39b-7218-0410-832d-ea1e28bc413d

deal.II/deal.II/source/fe/fe_poly_tensor.cc

index 6df60434200fda41133d3ee795885697c4ccd516..fa8812ced23ce13a8cb363df7db889c3374e23f1 100644 (file)
@@ -524,6 +524,7 @@ FE_PolyTensor<POLY,dim>::fill_fe_face_values (
                    for (unsigned int k=0; k<n_quad; ++k)
                      {
                        // Recompute determinant
+//TODO: Note that the Jacobian we compute here is that of the transformation from the reference FACE to the real FACE. However, what we need is the Jacobian of the transformation of the reference to the real CELL, which differs by one power of h. Consequently, the tests fe/rt_{11,13,14,15} presently compute the wrong results
                        double J = 1.0;
                        if (mapping_type == contravariant)
                          J = data.JxW_values[k] / quadrature.weight(k);
@@ -583,6 +584,7 @@ FE_PolyTensor<POLY,dim>::fill_fe_face_values (
                  for (unsigned int d=0;d<dim;++d)
                    {
                      // Recompute determinant
+//TODO: Note that the Jacobian we compute here is that of the transformation from the reference FACE to the real FACE. However, what we need is the Jacobian of the transformation of the reference to the real CELL, which differs by one power of h. Consequently, the tests fe/rt_{11,13,14,15} presently compute the wrong results
                      double J = data.JxW_values[k] / quadrature.weight(k);
                      data.shape_gradients[first+d][k] = sign_change[i] * 
                        shape_grads2[k][d] / J;

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.