]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Fix a few places for which we have the right answers after all. 11539/head
authorWolfgang Bangerth <bangerth@colostate.edu>
Thu, 14 Jan 2021 16:29:47 +0000 (09:29 -0700)
committerWolfgang Bangerth <bangerth@colostate.edu>
Thu, 14 Jan 2021 16:29:47 +0000 (09:29 -0700)
include/deal.II/fe/fe_interface_values.h
include/deal.II/fe/fe_tools.templates.h
include/deal.II/numerics/vector_tools_constraints.h

index 5887207b752b58657b4df44e0a7c280bd25a7872..eb2bb05eb845c5f2651a46e08ca7ba0a38e8029f 100644 (file)
@@ -526,34 +526,26 @@ FEInterfaceValues<dim, spacedim>::FEInterfaceValues(
   const UpdateFlags                   update_flags)
   : n_quadrature_points(quadrature.size())
   , internal_fe_face_values(
-      // TODO: We should query the default mapping for the kind of cell
-      // represented by 'fe' and 'q':
       ReferenceCell::get_default_linear_mapping<dim, spacedim>(
-        ReferenceCell::get_hypercube(dim)),
+        fe.reference_cell_type()),
       fe,
       quadrature,
       update_flags)
   , internal_fe_subface_values(
-      // TODO: We should query the default mapping for the kind of cell
-      // represented by 'fe' and 'q':
       ReferenceCell::get_default_linear_mapping<dim, spacedim>(
-        ReferenceCell::get_hypercube(dim)),
+        fe.reference_cell_type()),
       fe,
       quadrature,
       update_flags)
   , internal_fe_face_values_neighbor(
-      // TODO: We should query the default mapping for the kind of cell
-      // represented by 'fe' and 'q':
       ReferenceCell::get_default_linear_mapping<dim, spacedim>(
-        ReferenceCell::get_hypercube(dim)),
+        fe.reference_cell_type()),
       fe,
       quadrature,
       update_flags)
   , internal_fe_subface_values_neighbor(
-      // TODO: We should query the default mapping for the kind of cell
-      // represented by 'fe' and 'q':
       ReferenceCell::get_default_linear_mapping<dim, spacedim>(
-        ReferenceCell::get_hypercube(dim)),
+        fe.reference_cell_type()),
       fe,
       quadrature,
       update_flags)
index 137ab656e3d7857a2f72c9e3379b830c026bf68d..932a0552c02467983ff4373848ca8fd1922f8930 100644 (file)
@@ -2265,14 +2265,10 @@ namespace FETools
         tr.begin_active()->set_refine_flag(RefinementCase<dim>(ref_case));
         tr.execute_coarsening_and_refinement();
 
-        FEValues<dim, spacedim> fine(
-          // TODO: We should query the default mapping for the kind of cell
-          // represented by 'fe' and 'q':
-          ReferenceCell::get_default_linear_mapping<dim, spacedim>(
-            ReferenceCell::get_hypercube(dim)),
-          fe,
-          q_fine,
-          update_quadrature_points | update_JxW_values | update_values);
+        FEValues<dim, spacedim> fine(fe,
+                                     q_fine,
+                                     update_quadrature_points |
+                                       update_JxW_values | update_values);
 
         typename Triangulation<dim, spacedim>::cell_iterator coarse_cell =
           tr.begin(0);
index 84c6d56c7eca442b07dfee49b33bf98d968be4a2..b952a11fc22bb29ef865ac3d67cd94a433505805 100644 (file)
@@ -303,7 +303,7 @@ namespace VectorTools
     const std::set<types::boundary_id> &boundary_ids,
     AffineConstraints<double> &         constraints,
     const Mapping<dim, spacedim> &      mapping =
-      ReferenceCell::get_default_linear_mapping<dim,spacedim>(
+      ReferenceCell::get_default_linear_mapping<dim, spacedim>(
         ReferenceCell::get_hypercube(dim)));
 
   /**
@@ -332,7 +332,7 @@ namespace VectorTools
       &                           function_map,
     AffineConstraints<double> &   constraints,
     const Mapping<dim, spacedim> &mapping =
-      ReferenceCell::get_default_linear_mapping<dim,spacedim>(
+      ReferenceCell::get_default_linear_mapping<dim, spacedim>(
         ReferenceCell::get_hypercube(dim)));
 
   /**
@@ -351,7 +351,7 @@ namespace VectorTools
     const std::set<types::boundary_id> &boundary_ids,
     AffineConstraints<double> &         constraints,
     const Mapping<dim, spacedim> &      mapping =
-      ReferenceCell::get_default_linear_mapping<dim,spacedim>(
+      ReferenceCell::get_default_linear_mapping<dim, spacedim>(
         ReferenceCell::get_hypercube(dim)));
 
   //@}

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.