]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Address review comments 14628/head
authorDaniel Arndt <arndtd@ornl.gov>
Fri, 6 Jan 2023 18:29:54 +0000 (13:29 -0500)
committerDaniel Arndt <arndtd@ornl.gov>
Fri, 6 Jan 2023 18:29:54 +0000 (13:29 -0500)
include/deal.II/lac/affine_constraints.templates.h
tests/base/kokkos_point.cc
tests/base/kokkos_tensor_01.cc
tests/base/kokkos_tensor_02.cc
tests/lac/affine_constraints_set_zero.cc

index c5d27717ff1234b0fcc0cc375193acd7dc5e2699..8051db3ed7bdc7a26f0c87e67ab33c777f112d03 100644 (file)
@@ -2289,11 +2289,11 @@ namespace internal
       ExecutionSpace exec;
       auto           local_values = vec.get_values();
       Kokkos::parallel_for(
+        "set_zero_parallel",
         Kokkos::RangePolicy<ExecutionSpace>(exec, 0, n_constraints),
         KOKKOS_LAMBDA(int i) {
           local_values[constrained_local_dofs_device[i]] = 0;
         });
-      exec.fence();
 
       vec.zero_out_ghost_values();
     }
index 093069fc00c91fe725eedd0f75f5145fcdd0cc74..0ed4ba5bec24f0676f603d52dd898ae7abb2931a 100644 (file)
@@ -28,7 +28,6 @@ test_gpu()
   Kokkos::View<Number *, MemorySpace::Default::kokkos_space> check("check",
                                                                    n_tests);
 
-  // Miscellaneous
   using ExecutionSpace = MemorySpace::Default::kokkos_space::execution_space;
   ExecutionSpace exec;
   Kokkos::parallel_for(
@@ -83,8 +82,6 @@ test_gpu()
       check[15] = s_4;
     });
 
-  exec.fence();
-
   auto check_host =
     Kokkos::create_mirror_view_and_copy(Kokkos::HostSpace{}, check);
 
index db135575ff0960f89d1653e921928a6bdf7733cb..ac98facd079118c5848e434212a904fcf72ab394 100644 (file)
@@ -65,7 +65,6 @@ test_gpu()
       norm_dev()        = t_dev().norm();
       norm_square_dev() = t_dev().norm_square();
     });
-  exec.fence();
 
   // Copy the result to the host
   Kokkos::deep_copy(norm_host, norm_dev);
index 7581ecb9701f0670f93985ba96c86f59b5b83cfc..3c5310a92b99c32e19e985b14442f941107d9aa9 100644 (file)
@@ -28,7 +28,7 @@ struct InitFunctor<0, dim, Number>
   Kokkos::View<Tensor<0, dim, Number>, MemorySpace::Default::kokkos_space> t;
 
   KOKKOS_FUNCTION void
-  operator()(int k) const
+  operator()(int) const
   {
     t() = 1.;
   }
index e64475d28406695c67c3b58be7927ffac9cd744d..1ee19d691971a4a3df10c60fbad3dc1b6ad8a024 100644 (file)
@@ -63,7 +63,6 @@ test()
         int offset        = myid * numproc;
         ghosted_values[i] = 1.0 + i + offset;
       });
-    exec.fence();
     ghosted.compress(VectorOperation::insert);
 
     deallog << "ghosted vector before:" << std::endl;

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.