]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Add some comments describing our orientation implementation. 14737/head
authorDavid Wells <drwells@email.unc.edu>
Thu, 26 Jan 2023 03:32:44 +0000 (22:32 -0500)
committerDavid Wells <drwells@email.unc.edu>
Thu, 26 Jan 2023 22:16:01 +0000 (17:16 -0500)
include/deal.II/grid/reference_cell.h

index 286f7f28550b36fd193f96d5e46f043598cd3581..c65f7ae2bd65b6f7c85e62eb8201d2dcff9049b2 100644 (file)
@@ -1445,7 +1445,10 @@ ReferenceCell::face_reference_cell(const unsigned int face_no) const
 inline constexpr unsigned char
 ReferenceCell::default_combined_face_orientation()
 {
-  return 1u;
+  // Our convention is that 'orientation' has a default value of true and
+  // occupies the least-significant bit while rotate and flip have default
+  // values of 'false' and occupy the second and third bits.
+  return 0b001;
 }
 
 
@@ -1453,7 +1456,9 @@ ReferenceCell::default_combined_face_orientation()
 inline constexpr unsigned char
 ReferenceCell::reversed_combined_line_orientation()
 {
-  return 0u;
+  // For a reversed line 'orientation' is false and neither flip nor rotate are
+  // defined.
+  return 0b000;
 }
 
 

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.