]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Add a changelog entry for the Manifold incompatibities. 4723/head
authorDavid Wells <wellsd2@rpi.edu>
Mon, 11 Sep 2017 02:52:54 +0000 (22:52 -0400)
committerDavid Wells <wellsd2@rpi.edu>
Mon, 11 Sep 2017 18:17:10 +0000 (14:17 -0400)
doc/news/changes/incompatibilities/20170910DavidWells [new file with mode: 0644]

diff --git a/doc/news/changes/incompatibilities/20170910DavidWells b/doc/news/changes/incompatibilities/20170910DavidWells
new file mode 100644 (file)
index 0000000..7714bbf
--- /dev/null
@@ -0,0 +1,19 @@
+Changed: The methods
+<ol>
+  <li>Manifold::get_new_point</li>
+  <li>Manifold::project_to_manifold</li>
+</ol>
+have had their declarations changed in an incompatible manner: these three
+methods now take ArrayView arguments instead of <code>std::vector</code>s. This
+change was done for performance reasons: before this change about a third of the
+time spent generating a curved grid (in this particular benchmark, a circle
+described with polar coordinates and a transfinite interpolation) was used in
+allocating and freeing memory used by the <code>std::vector</code> arguments to
+Manifold::get_new_point() even though the sizes of the arrays are usually known
+at compilation time. This change completely eliminates this allocation cost.
+
+The method <code>Manifold::add_new_points()</code> has been removed in favor of
+Manifold::get_new_points(), which also uses ArrayView arguments instead of
+<code>std::vector</code>s.
+<br>
+(David Wells, 2017/09/10)

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.