]> https://gitweb.dealii.org/ - dealii.git/commitdiff
Better document one place. 6009/head
authorWolfgang Bangerth <bangerth@colostate.edu>
Thu, 8 Mar 2018 14:54:25 +0000 (07:54 -0700)
committerWolfgang Bangerth <bangerth@colostate.edu>
Thu, 8 Mar 2018 14:54:25 +0000 (07:54 -0700)
source/dofs/dof_handler_policy.cc

index 8b20aa899be69d71dd132b43ea81233f2c62bc61..deb86f68617378aa61b01e1a78d8b786ad6e813c 100644 (file)
@@ -4114,8 +4114,19 @@ namespace internal
                                      triangulation->coarse_cell_to_p4est_tree_permutation,
                                      triangulation->p4est_tree_to_coarse_cell_permutation);
 
-          // This barrier is crucial so that messages between phases
-          // 1&2 don't mix.
+          // have a barrier so that sends from above and below this
+          // place are not mixed up.
+          //
+          // this is necessary because above we just see if there are
+          // messages and then receive them, without discriminating
+          // where they come from and whether they were sent in phase
+          // 1 or 2 in communicate_mg_ghost_cells() on another
+          // processor. the need for a global communication step like
+          // this barrier could be avoided by receiving messages
+          // specifically from those processors from which we expect
+          // messages, and by using different tags for phase 1 and 2,
+          // but the cost of a barrier is negligible compared to
+          // everything else we do here
           const int ierr = MPI_Barrier(triangulation->get_communicator());
           AssertThrowMPI(ierr);
 

In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move.

Douglas Adams


Typeset in Trocchi and Trocchi Bold Sans Serif.