From: bangerth Date: Thu, 25 Aug 2011 19:13:06 +0000 (+0000) Subject: Leave two TODOs. X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=060b5233e8bddd507bec231738b8d7791074a559;p=dealii-svn.git Leave two TODOs. git-svn-id: https://svn.dealii.org/trunk@24203 0785d39b-7218-0410-832d-ea1e28bc413d --- diff --git a/deal.II/source/base/utilities.cc b/deal.II/source/base/utilities.cc index 03802b0f5f..d4984d80ac 100644 --- a/deal.II/source/base/utilities.cc +++ b/deal.II/source/base/utilities.cc @@ -142,10 +142,14 @@ namespace Utilities int i = max_int; ss >> i; - // check for errors AssertThrow (i != max_int, ExcCantConvertString (s)); +//TODO: The test for errors above doesn't work, as can easily be +//verified. furthermore, it doesn't catch cases like when calling +//string_to_int("1.23.4") since it just reads in however much it can, without +//realizing that there is more + return i; } @@ -179,6 +183,11 @@ namespace Utilities // check for errors AssertThrow (i != max_double, ExcCantConvertString (s)); +//TODO: The test for errors above doesn't work, as can easily be +//verified. furthermore, it doesn't catch cases like when calling +//string_to_int("1.23.4") since it just reads in however much it can, without +//realizing that there is more + return i; }