From: wolf <wolf@0785d39b-7218-0410-832d-ea1e28bc413d>
Date: Wed, 9 Jan 2002 15:43:13 +0000 (+0000)
Subject: No more abort a program in Assert() if another (C++) exception is active.
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=140db8ee5019aea248fca8f5ae5a18485074cc5c;p=dealii-svn.git

No more abort a program in Assert() if another (C++) exception is active.


git-svn-id: https://svn.dealii.org/trunk@5369 0785d39b-7218-0410-832d-ea1e28bc413d
---

diff --git a/deal.II/base/include/base/exceptions.h b/deal.II/base/include/base/exceptions.h
index 372676f977..e0c21fbc88 100644
--- a/deal.II/base/include/base/exceptions.h
+++ b/deal.II/base/include/base/exceptions.h
@@ -144,11 +144,12 @@
  *  normally created using the @p{DeclException (...)} macro
  *  family.
  *
- *  After printing all this information, @p{abort()} is called.
- *  This terminates the program, which is the right thing to do for
- *  this kind of error checking since it is used to detect programming
- *  errors rather than run-time errors; a program can, by definition,
- *  not recover from programming errors.
+ *  After printing all this information, @p{abort()} is called (with
+ *  one exception, see the end of this section). This terminates the
+ *  program, which is the right thing to do for this kind of error
+ *  checking since it is used to detect programming errors rather than
+ *  run-time errors; a program can, by definition, not recover from
+ *  programming errors.
  *
  *  If the preprocessor variable @p{DEBUG} is not set, then nothing
  *  happens, i.e. the @p{Assert} macro is expanded to @p{{}}.
@@ -161,6 +162,24 @@
  *    Assert (false, ExcInternalError());
  *  @end{verbatim}
  *
+ *  As mentioned above, the program is terminated once a call to
+ *  @p{Assert} fails. However, there is one case where we do not want
+ *  to do this, namely when a C++ exception is active. The usual case
+ *  where this happens is that someone throws an exception through the
+ *  @p{AssertThrow} mechanism (see below) which, while the stack is
+ *  unwound, leads to the destruction of other objects in stack frames
+ *  above. If other objects refer to the objects being thus destroyed,
+ *  some destructors raise an exception through @p{Assert}. If we
+ *  would abort the program then, we would only ever see the message
+ *  that an object is being destroyed which is still referenced from
+ *  somewhere, but we would never see the original exception that
+ *  triggered this. (You can see it in the debugger by putting a break
+ *  point on the function @p{__throw}, but you cannot see it from the
+ *  program itself.) In that case, we use a C++ standard library
+ *  function to detect the presence of another active exception and do
+ *  not terminate the program to allow that the thrown exception
+ *  propagates to some place where its message can be displayed.
+ *
  *
  *  @sect2{Use of run-time exceptions}
  *
@@ -404,8 +423,24 @@ void __IssueError_Assert (const char *file,
   e.PrintInfo (std::cerr);
   std::cerr << "--------------------------------------------------------"
 	    << std::endl;
-  
-  std::abort ();
+
+				   // abort the program now since
+				   // something has gone horribly
+				   // wrong. however, there is one
+				   // case where we do not want to do
+				   // that, namely when another
+				   // exception, possibly thrown by
+				   // AssertThrow is active, since in
+				   // that case we will not come to
+				   // see the original exception. in
+				   // that case indicate that the
+				   // program is not aborted due to
+				   // this reason
+  if (std::uncaught_exception() == true)
+    std::cerr << "******** Program is not aborted since another exception is active! ********"
+	      << std::endl;
+  else
+    std::abort ();
 };
 
 
diff --git a/deal.II/doc/news/2001/c-3-2.html b/deal.II/doc/news/2001/c-3-2.html
index 9c668991a6..49fecc549c 100644
--- a/deal.II/doc/news/2001/c-3-2.html
+++ b/deal.II/doc/news/2001/c-3-2.html
@@ -107,6 +107,17 @@ documentation, etc</a>.
 <h3>base</h3>
 
 <ol>
+  <li> <p>
+       Changed: when an assertion fails in the <code
+       class="member">Assert()</code> function, the program is usually
+       aborted. Don't abort it any more if there is an active C++
+       somewhere since we would lose its message if we aborted the
+       program. In that case only report the error and write out an
+       indication why we do not abort the program any more.
+       <br>
+       (WB 2002/01/09)
+       </p>
+
   <li> <p>
        New: <code class="class">ExcFileNotOpen</code> can be used
        after initializing an <code class="class">fstream</code>