From: David Wells Date: Mon, 13 May 2019 14:58:24 +0000 (-0400) Subject: cppcheck: remove a duplicate static constant. X-Git-Tag: v9.1.0-rc1~18^2~4 X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=25866b75d39af1da4a3149fbf92e6d145762714e;p=dealii.git cppcheck: remove a duplicate static constant. This is the same as the one in the base class. --- diff --git a/include/deal.II/lac/sparsity_pattern.h b/include/deal.II/lac/sparsity_pattern.h index e87ca818e2..9229da2dc0 100644 --- a/include/deal.II/lac/sparsity_pattern.h +++ b/include/deal.II/lac/sparsity_pattern.h @@ -884,22 +884,6 @@ public: */ using SparsityPatternBase::reinit; - /** - * Define a value which is used to indicate that a certain value in the - * #colnums array is unused, i.e. does not represent a certain column number - * index. - * - * Indices with this invalid value are used to insert new entries to the - * sparsity pattern using the add() member function, and are removed when - * calling compress(). - * - * You should not assume that the variable declared here has a certain - * value. The initialization is given here only to enable the compiler to - * perform some optimizations, but the actual value of the variable may - * change over time. - */ - static const size_type invalid_entry = SparsityPatternBase::invalid_entry; - /** * @name Construction and setup Constructors, destructor; functions * initializing, copying and filling an object. diff --git a/source/lac/sparsity_pattern.cc b/source/lac/sparsity_pattern.cc index 17c1e7de4d..3e567f6f93 100644 --- a/source/lac/sparsity_pattern.cc +++ b/source/lac/sparsity_pattern.cc @@ -34,8 +34,7 @@ DEAL_II_NAMESPACE_OPEN #ifdef DEAL_II_MSVC __declspec(selectany) // Weak extern binding due to multiple link error #endif - const SparsityPattern::size_type SparsityPattern::invalid_entry; -const SparsityPatternBase::size_type SparsityPatternBase::invalid_entry; + const SparsityPatternBase::size_type SparsityPatternBase::invalid_entry; SparsityPatternBase::SparsityPatternBase()