From: Wolfgang Bangerth <bangerth@colostate.edu>
Date: Wed, 6 Jul 2022 17:52:45 +0000 (-0600)
Subject: Better document what tolerance to use in MappingCartesian.
X-Git-Tag: v9.5.0-rc1~1103^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3878e3934b7400b7f4f1d01dd9f7b578999eeff4;p=dealii.git

Better document what tolerance to use in MappingCartesian.
---

diff --git a/source/fe/mapping_cartesian.cc b/source/fe/mapping_cartesian.cc
index 47349a5dd1..1620af218e 100644
--- a/source/fe/mapping_cartesian.cc
+++ b/source/fe/mapping_cartesian.cc
@@ -55,19 +55,28 @@ is_cartesian(const CellType &cell)
   if (!cell->reference_cell().is_hyper_cube())
     return false;
 
-  const double tolerance         = 1e-14;
+  const double abs_tol           = 1e-15;
+  const double rel_tol           = 1e-14;
   const auto   bounding_box      = cell->bounding_box();
   const auto & bounding_vertices = bounding_box.get_boundary_points();
-  const auto   cell_measure =
+  const auto   bb_diagonal_length_squared =
     bounding_vertices.first.distance_square(bounding_vertices.second);
 
   for (const unsigned int v : cell->vertex_indices())
     {
-      const double vertex_tolerance =
-        tolerance * std::max(cell->vertex(v).norm_square(), cell_measure);
-
-      if (cell->vertex(v).distance_square(bounding_box.vertex(v)) >
-          vertex_tolerance)
+      // Choose a tolerance that takes into account both that vertices far
+      // away from the origin have only a finite number of digits
+      // that are considered correct (an "absolute tolerance"), as well as that
+      // vertices are supposed to be close to the corresponding vertices of the
+      // bounding box (a tolerance that is "relative" to the size of the cell).
+      //
+      // We need to do it this way because when a vertex is far away from
+      // the origin, computing the difference between two vertices is subject
+      // to cancellation.
+      const double tolerance = std::max(abs_tol * cell->vertex(v).norm_square(),
+                                        rel_tol * bb_diagonal_length_squared);
+
+      if (cell->vertex(v).distance_square(bounding_box.vertex(v)) > tolerance)
         return false;
     }