From: Matthias Maier <tamiko@43-1.org>
Date: Mon, 26 Dec 2022 04:01:03 +0000 (-0600)
Subject: CMake: avoid race conditions between concurrent prm tests
X-Git-Tag: v9.5.0-rc1~706^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3e5ca655adbe8b9110ecfb5dc9f9dc28a34dd1ff;p=dealii.git

CMake: avoid race conditions between concurrent prm tests

We need to serialize all tests that share a common executable target.
This involves tests with .threads=N. and .mpirun=N. annotation, as well
as tests with parameter files (that might share a common executable
target).

Running multiple variants of tests with the same target executable in
parallel triggers a race condition where the same (not yet existent)
target is built concurrently leading to undefined outcomes.
---

diff --git a/cmake/macros/macro_deal_ii_add_test.cmake b/cmake/macros/macro_deal_ii_add_test.cmake
index 73c3cd6af4..6cafff1385 100644
--- a/cmake/macros/macro_deal_ii_add_test.cmake
+++ b/cmake/macros/macro_deal_ii_add_test.cmake
@@ -571,11 +571,19 @@ function(deal_ii_add_test _category _test_name _comparison_file)
         set_tests_properties(${_test_full} PROPERTIES PROCESSORS ${_slots})
       endif()
 
-      if(NOT "${_n_cpu}${_n_threads}" STREQUAL "00")
+      #
+      # Serialize all tests that share a common executable target. This
+      # involves tests with .threads=N. and .mpirun=N. annotation, as well
+      # as tests with parameter files (that might share a common executable
+      # target).
+      #
+      if( NOT "${_n_cpu}${_n_threads}" STREQUAL "00" OR
+          "${_source_file}" MATCHES "(prm|json)$" )
         #
-        # Running multiple variants in parallel triggers a race condition
-        # where the same (not yet existent) executable is built
-        # concurrently leading to undefined outcomes.
+        # Running multiple variants of tests with the same target
+        # executable in parallel triggers a race condition where the same
+        # (not yet existent) target is built concurrently leading to
+        # undefined outcomes.
         #
         # Luckily CMake has a mechanism to force a test to be run after
         # another has finished (and both are scheduled):