From: Daniel Arndt <arndtd@ornl.gov>
Date: Sun, 2 Jul 2023 15:20:26 +0000 (-0400)
Subject: Remove deprecated MatrixFree::FE[Face]::Evaluation functions taking bools
X-Git-Tag: relicensing~774^2~1
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=49f0fe5261c4413da78cf671714608c95b522612;p=dealii.git

Remove deprecated MatrixFree::FE[Face]::Evaluation functions taking bools
---

diff --git a/doc/news/changes/incompatibilities/20230702DanielArndt-5 b/doc/news/changes/incompatibilities/20230702DanielArndt-5
new file mode 100644
index 0000000000..704b2db346
--- /dev/null
+++ b/doc/news/changes/incompatibilities/20230702DanielArndt-5
@@ -0,0 +1,5 @@
+Removed: The deprecated MatrixFree::FEEvaluation
+and MatrixFreeFaceEvaluation member function taking
+bools instead of EvaluationFlags have been removed.
+<br>
+(Daniel Arndt, 2023/07/02)
diff --git a/include/deal.II/matrix_free/fe_evaluation.h b/include/deal.II/matrix_free/fe_evaluation.h
index a47e64c23d..51ae971c61 100644
--- a/include/deal.II/matrix_free/fe_evaluation.h
+++ b/include/deal.II/matrix_free/fe_evaluation.h
@@ -2677,15 +2677,6 @@ public:
   gather_evaluate(const VectorType &                     input_vector,
                   const EvaluationFlags::EvaluationFlags evaluation_flag);
 
-  /**
-   * @deprecated Please use the gather_evaluate() function with the EvaluationFlags argument.
-   */
-  template <typename VectorType>
-  DEAL_II_DEPRECATED void
-  gather_evaluate(const VectorType &input_vector,
-                  const bool        evaluate_values,
-                  const bool        evaluate_gradients);
-
   /**
    * This function takes the values and/or gradients that are stored on
    * quadrature points, tests them by all the basis functions/gradients on the
@@ -2698,12 +2689,6 @@ public:
   void
   integrate(const EvaluationFlags::EvaluationFlags integration_flag);
 
-  /**
-   * @deprecated Please use the integrate() function with the EvaluationFlags argument.
-   */
-  DEAL_II_DEPRECATED void
-  integrate(const bool integrate_values, const bool integrate_gradients);
-
   /**
    * This function takes the values and/or gradients that are stored on
    * quadrature points, tests them by all the basis functions/gradients on the
@@ -2716,14 +2701,6 @@ public:
   integrate(const EvaluationFlags::EvaluationFlags integration_flag,
             VectorizedArrayType *                  values_array);
 
-  /**
-   * @deprecated Please use the integrate() function with the EvaluationFlags argument.
-   */
-  DEAL_II_DEPRECATED void
-  integrate(const bool           integrate_values,
-            const bool           integrate_gradients,
-            VectorizedArrayType *values_array);
-
   /**
    * This function takes the values and/or gradients that are stored on
    * quadrature points, tests them by all the basis functions/gradients on the
@@ -8847,57 +8824,6 @@ FEFaceEvaluation<dim,
 
 
 
-template <int dim,
-          int fe_degree,
-          int n_q_points_1d,
-          int n_components_,
-          typename Number,
-          typename VectorizedArrayType>
-inline void
-FEFaceEvaluation<dim,
-                 fe_degree,
-                 n_q_points_1d,
-                 n_components_,
-                 Number,
-                 VectorizedArrayType>::integrate(const bool integrate_values,
-                                                 const bool integrate_gradients)
-{
-  integrate(integrate_values, integrate_gradients, this->values_dofs);
-
-#  ifdef DEBUG
-  this->dof_values_initialized = true;
-#  endif
-}
-
-
-
-template <int dim,
-          int fe_degree,
-          int n_q_points_1d,
-          int n_components_,
-          typename Number,
-          typename VectorizedArrayType>
-inline void
-FEFaceEvaluation<dim,
-                 fe_degree,
-                 n_q_points_1d,
-                 n_components_,
-                 Number,
-                 VectorizedArrayType>::integrate(const bool integrate_values,
-                                                 const bool integrate_gradients,
-                                                 VectorizedArrayType
-                                                   *values_array)
-{
-  const EvaluationFlags::EvaluationFlags flag =
-    ((integrate_values) ? EvaluationFlags::values : EvaluationFlags::nothing) |
-    ((integrate_gradients) ? EvaluationFlags::gradients :
-                             EvaluationFlags::nothing);
-
-  integrate(flag, values_array);
-}
-
-
-
 template <int dim,
           int fe_degree,
           int n_q_points_1d,
@@ -8971,34 +8897,6 @@ FEFaceEvaluation<dim,
 
 
 
-template <int dim,
-          int fe_degree,
-          int n_q_points_1d,
-          int n_components_,
-          typename Number,
-          typename VectorizedArrayType>
-template <typename VectorType>
-inline void
-FEFaceEvaluation<
-  dim,
-  fe_degree,
-  n_q_points_1d,
-  n_components_,
-  Number,
-  VectorizedArrayType>::gather_evaluate(const VectorType &input_vector,
-                                        const bool        evaluate_values,
-                                        const bool        evaluate_gradients)
-{
-  const EvaluationFlags::EvaluationFlags flag =
-    ((evaluate_values) ? EvaluationFlags::values : EvaluationFlags::nothing) |
-    ((evaluate_gradients) ? EvaluationFlags::gradients :
-                            EvaluationFlags::nothing);
-
-  gather_evaluate(input_vector, flag);
-}
-
-
-
 template <int dim,
           int fe_degree,
           int n_q_points_1d,
diff --git a/tests/matrix_free/ecl.h b/tests/matrix_free/ecl.h
index 8f239879a8..74c7dda29e 100644
--- a/tests/matrix_free/ecl.h
+++ b/tests/matrix_free/ecl.h
@@ -186,9 +186,9 @@ test(const unsigned int geometry      = 0,
               phi_m.submit_value(average_valgrad, q);
               phi_p.submit_value(-average_valgrad, q);
             }
-          phi_m.integrate(true, true);
+          phi_m.integrate(EvaluationFlags::values | EvaluationFlags::gradients);
           phi_m.distribute_local_to_global(dst);
-          phi_p.integrate(true, true);
+          phi_p.integrate(EvaluationFlags::values | EvaluationFlags::gradients);
           phi_p.distribute_local_to_global(dst);
         }
     },
diff --git a/tests/matrix_free/interpolate_quadrature_01.cc b/tests/matrix_free/interpolate_quadrature_01.cc
index b051701bd5..3311107579 100644
--- a/tests/matrix_free/interpolate_quadrature_01.cc
+++ b/tests/matrix_free/interpolate_quadrature_01.cc
@@ -110,7 +110,7 @@ test(const unsigned int n_refinements = 1)
                face++)
             {
               phi_m.reinit(cell, face);
-              phi_m.gather_evaluate(src, true, false);
+              phi_m.gather_evaluate(src, EvaluationFlags::values);
 
               AlignedVector<VectorizedArrayType> temp(
                 phi_m.static_dofs_per_cell);
diff --git a/tests/matrix_free/pbc_orientation_01.cc b/tests/matrix_free/pbc_orientation_01.cc
index 22c895bda2..cf0e9fd30e 100644
--- a/tests/matrix_free/pbc_orientation_01.cc
+++ b/tests/matrix_free/pbc_orientation_01.cc
@@ -177,9 +177,9 @@ test()
                face++)
             {
               eval_minus.reinit(face);
-              eval_minus.gather_evaluate(src, true, false);
+              eval_minus.gather_evaluate(src, EvaluationFlags::values);
               eval_plus.reinit(face);
-              eval_plus.gather_evaluate(src, true, false);
+              eval_plus.gather_evaluate(src, EvaluationFlags::values);
 
               for (unsigned int q = 0; q < eval_minus.n_q_points; ++q)
                 {
diff --git a/tests/matrix_free/pbc_orientation_02.cc b/tests/matrix_free/pbc_orientation_02.cc
index 1b5f150c19..958d6efc5b 100644
--- a/tests/matrix_free/pbc_orientation_02.cc
+++ b/tests/matrix_free/pbc_orientation_02.cc
@@ -186,9 +186,9 @@ test()
                   continue;
 
                 eval_minus.reinit(cell, face);
-                eval_minus.gather_evaluate(src, true, false);
+                eval_minus.gather_evaluate(src, EvaluationFlags::values);
                 eval_plus.reinit(cell, face);
-                eval_plus.gather_evaluate(src, true, false);
+                eval_plus.gather_evaluate(src, EvaluationFlags::values);
 
                 for (unsigned int q = 0; q < eval_minus.n_q_points; ++q)
                   {
diff --git a/tests/simplex/step-12c.cc b/tests/simplex/step-12c.cc
index 8c80046ec0..187073125a 100644
--- a/tests/simplex/step-12c.cc
+++ b/tests/simplex/step-12c.cc
@@ -804,9 +804,9 @@ public:
              ++cell)
           {
             phi_m.reinit(cell);
-            phi_m.gather_evaluate(src, true, false);
+            phi_m.gather_evaluate(src, EvaluationFlags::values);
             phi_p.reinit(cell);
-            phi_p.gather_evaluate(src, true, false);
+            phi_p.gather_evaluate(src, EvaluationFlags::values);
             for (unsigned int q = 0; q < phi_m.n_q_points; ++q)
               {
                 const auto beta_n = this->beta(phi_m.quadrature_point(q)) *