From: Wolfgang Bangerth <bangerth@colostate.edu>
Date: Fri, 28 Jan 2022 04:25:16 +0000 (-0700)
Subject: Use copy constructors for manifolds in clone().
X-Git-Tag: v9.4.0-rc1~552^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5a1ad8178cc2df266a51281dd3bfe3d83a313836;p=dealii.git

Use copy constructors for manifolds in clone().
---

diff --git a/source/grid/manifold_lib.cc b/source/grid/manifold_lib.cc
index ad4ad875a9..1b9ad3730c 100644
--- a/source/grid/manifold_lib.cc
+++ b/source/grid/manifold_lib.cc
@@ -138,7 +138,7 @@ template <int dim, int spacedim>
 std::unique_ptr<Manifold<dim, spacedim>>
 PolarManifold<dim, spacedim>::clone() const
 {
-  return std::make_unique<PolarManifold<dim, spacedim>>(center);
+  return std::make_unique<PolarManifold<dim, spacedim>>(*this);
 }
 
 
@@ -369,7 +369,7 @@ template <int dim, int spacedim>
 std::unique_ptr<Manifold<dim, spacedim>>
 SphericalManifold<dim, spacedim>::clone() const
 {
-  return std::make_unique<SphericalManifold<dim, spacedim>>(center);
+  return std::make_unique<SphericalManifold<dim, spacedim>>(*this);
 }
 
 
@@ -1080,9 +1080,7 @@ template <int dim, int spacedim>
 std::unique_ptr<Manifold<dim, spacedim>>
 CylindricalManifold<dim, spacedim>::clone() const
 {
-  return std::make_unique<CylindricalManifold<dim, spacedim>>(direction,
-                                                              point_on_axis,
-                                                              tolerance);
+  return std::make_unique<CylindricalManifold<dim, spacedim>>(*this);
 }
 
 
@@ -1237,10 +1235,7 @@ template <int dim, int spacedim>
 std::unique_ptr<Manifold<dim, spacedim>>
 EllipticalManifold<dim, spacedim>::clone() const
 {
-  const double eccentricity = 1.0 / cosh_u;
-  return std::make_unique<EllipticalManifold<dim, spacedim>>(center,
-                                                             direction,
-                                                             eccentricity);
+  return std::make_unique<EllipticalManifold<dim, spacedim>>(*this);
 }