From: Wolfgang Bangerth Date: Thu, 29 Mar 2001 15:26:59 +0000 (+0000) Subject: Move contents of TODO file into .h and .cc files. X-Git-Tag: v8.0.0~19446 X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b4fb0da95713a2089c503ba09bc35fdcd3b8ab7;p=dealii.git Move contents of TODO file into .h and .cc files. git-svn-id: https://svn.dealii.org/trunk@4334 0785d39b-7218-0410-832d-ea1e28bc413d --- diff --git a/deal.II/base/Todo b/deal.II/base/Todo deleted file mode 100644 index e5351d5b00..0000000000 --- a/deal.II/base/Todo +++ /dev/null @@ -1,38 +0,0 @@ -================================================================= -====== Things to be done for the /base library ================ -================================================================= - -Move the exceptions in the Tensor package (tensor_base.h and tensor.h) - back into the Tensor class, if the compiler allows to do so. Also - rename them back (i.e. drop the initial Tensor* from the name). - - - -Think about the determinant function in the tensor package. Is it - useful, can it be generalized? -> There are only non-zero alternating real valued n-forms, so a determinant -> exists only for Tensor, k even - -Put Tensor<1,dim>::array_size directly into the array type. At - present, egcs 1.1.2 chokes on that. - - -Fill in docs for the timer class. Hopefully finally find a way to - let it measure times larger than half an hour. -> Operating system dependence. Grrr. Guido - - -Revert istrstream(p.c_str()) to istrstream(p) when possible - (parameter_handler.cc) - - -Change to in grid/point.h and - grid/tria_iterator.h when this becomes possible. - - -Document the JobIdentifier class members. - - -Use numeric_limits to designate the default values of bounds - parameters of Patterns::Integer and Patterns::Double. This would then - allow to use half-open intervals as well, amoung other advantages. diff --git a/deal.II/base/include/base/job_identifier.h b/deal.II/base/include/base/job_identifier.h index ac9e87db0b..6abc06a02e 100644 --- a/deal.II/base/include/base/job_identifier.h +++ b/deal.II/base/include/base/job_identifier.h @@ -37,6 +37,7 @@ class JobIdentifier /** * ??? */ +//TODO:[GK] document this variable static const char* program_id(); /** diff --git a/deal.II/base/include/base/parameter_handler.h b/deal.II/base/include/base/parameter_handler.h index 81f1a4e8f2..f5e3ceb9ae 100644 --- a/deal.II/base/include/base/parameter_handler.h +++ b/deal.II/base/include/base/parameter_handler.h @@ -14,6 +14,12 @@ #define __deal2__parameter_handler_h +//TODO:[WB] Use numeric_limits to designate the default values of bounds parameters +// of Patterns::Integer and Patterns::Double. This would then allow to use half-open +// intervals as well, among other advantages. + + + // public classes; to be declared below class ParameterHandler; class MultipleParameterLoop; @@ -24,9 +30,11 @@ class MultipleParameterLoop; #include #include + // forward declaration class LogStream; + /** * List of possible output formats. */ @@ -35,6 +43,7 @@ enum OutputStyle { }; + /** * Declare some regexps which * may be used to define patterns. diff --git a/deal.II/base/include/base/tensor.h b/deal.II/base/include/base/tensor.h index 1656ed9af2..cf4d690a08 100644 --- a/deal.II/base/include/base/tensor.h +++ b/deal.II/base/include/base/tensor.h @@ -392,6 +392,7 @@ Tensor::memory_consumption () be properly accessed (haven't investigated why). If anyone has a better idea, realize it! */ +//TODO:[WB] move the exceptions back into the Tensor class, if the compiler allows to do so. Also rename them back (i.e. drop the initial Tensor* from the name) DeclException1 (ExcInvalidTensorIndex, int, << "Invalid tensor index " << arg1); diff --git a/deal.II/base/include/base/tensor_base.h b/deal.II/base/include/base/tensor_base.h index de0eed9e20..ef65282796 100644 --- a/deal.II/base/include/base/tensor_base.h +++ b/deal.II/base/include/base/tensor_base.h @@ -19,6 +19,9 @@ // tensor stuff, so we don't want the whole tensor package to be included // everytime we use a point. + +//TODO:[WB] Change to when that becomes available + #include #include #include @@ -68,37 +71,16 @@ class Tensor<1,dim> */ static const unsigned int rank = 1; -#if (__GNUC__==2) && (__GNUC_MINOR__ < 95) - /** - * Unnecessary variable, only used in - * the declaration of @p{array_type}. - * This variable should be omitted, - * but egcs1.1.2 chokes on that so - * we need it presently. - */ - static const unsigned int array_size = ((dim!=0) ? (dim) : 1); - /** * Declare an array type which can * be used to initialize statically * an object of this type. * - * Use the same condition for @p{dim==0} - * as in the @p{TensorBase<1,dim>} class. + * Avoid warning about zero-sized + * array for @p{dim==0} by + * choosing lunatic value. */ - typedef double array_type[array_size]; -#else - - /** - * Declare an array type which can - * be used to initialize statically - * an object of this type. - * - * Use the same condition for @p{dim==0} - * as in the @p{TensorBase<1,dim>} class. - */ - typedef double array_type[(dim!=0) ? dim : 1]; -#endif + typedef double array_type[(dim!=0) ? dim : (unsigned int)(-1)]; /** * Constructor. Initialize all entries @@ -262,6 +244,7 @@ class Tensor<1,dim> /** * Exception */ +//TODO:[WB] move the exceptions back into the Tensor class, if the compiler allows to do so. Also rename them back (i.e. drop the initial Tensor* from the name) DeclException2(ExcWrongVectorSize, int, int, << "Tensor has " << arg1 << " entries, but vector has size " << arg2); DeclException1 (ExcDimTooSmall, diff --git a/deal.II/base/include/base/timer.h b/deal.II/base/include/base/timer.h index b82935f93f..43e2a6a514 100644 --- a/deal.II/base/include/base/timer.h +++ b/deal.II/base/include/base/timer.h @@ -49,6 +49,7 @@ * * @author G. Kanschat, W. Bangerth */ +//TODO:[?] make class work with multithreading as well. better docs. class Timer { public: diff --git a/deal.II/base/source/exceptions.cc b/deal.II/base/source/exceptions.cc index ecc12b110c..058b10d8eb 100644 --- a/deal.II/base/source/exceptions.cc +++ b/deal.II/base/source/exceptions.cc @@ -12,6 +12,10 @@ //---------------------------- exceptions.cc --------------------------- +//TODO:[WB] use [io]stringstream instead of [io]strstream if they become available +//TODO:[WB] replace s.c_str() by s when that is possible + + #include #include #include diff --git a/deal.II/base/source/parameter_handler.cc b/deal.II/base/source/parameter_handler.cc index ea695925b8..8a5abf354d 100644 --- a/deal.II/base/source/parameter_handler.cc +++ b/deal.II/base/source/parameter_handler.cc @@ -12,6 +12,9 @@ //---------------------------- parameter_handler.cc --------------------------- +//TODO:[WB] use [io]stringstream instead of [io]strstream if they become available +//TODO:[WB] replace s.c_str() by s when that is possible + #include #include #include