From: Daniel Arndt <arndtd@ornl.gov>
Date: Mon, 25 May 2020 20:18:10 +0000 (-0400)
Subject: Compile MSVC testers with warnings as errors
X-Git-Tag: v9.3.0-rc1~1553^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5ba23638f127b781ca67d2cd262b688017ca65c5;p=dealii.git

Compile MSVC testers with warnings as errors
---

diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
index c3265c95f7..b7a59f4f66 100644
--- a/.github/workflows/windows.yml
+++ b/.github/workflows/windows.yml
@@ -8,6 +8,7 @@ jobs:
     name: Windows Serial
     runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
         os: [windows-2019, windows-2016]
 
@@ -23,7 +24,7 @@ jobs:
         mkdir build
         mkdir c:/project
         cd build
-        cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=c:/project -T host=x64 ..
+        cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=c:/project -DDEAL_II_CXX_FLAGS="-WX" -T host=x64 ..
     - name: archive logs
       uses: actions/upload-artifact@v1
       with:
diff --git a/cmake/checks/check_01_cxx_features.cmake b/cmake/checks/check_01_cxx_features.cmake
index 43e08a8500..aca3421b23 100644
--- a/cmake/checks/check_01_cxx_features.cmake
+++ b/cmake/checks/check_01_cxx_features.cmake
@@ -261,7 +261,7 @@ MACRO(_test_cxx14_support)
     int main()
     {
       std::condition_variable c;
-      p[0];
+      p[0] = 1;
       c.notify_all();
 
      // type traits functionality
diff --git a/contrib/ci/appveyor.yml b/contrib/ci/appveyor.yml
index 58b6a0781b..b141d4d791 100644
--- a/contrib/ci/appveyor.yml
+++ b/contrib/ci/appveyor.yml
@@ -5,7 +5,7 @@ build_script:
 - cmd: >-
     mkdir build &&
     cd build &&
-    cmake c:\projects\source -DCMAKE_BUILD_TYPE=Debug -G "Visual Studio 16 2019" -DCMAKE_INSTALL_PREFIX="c:\projects\dealii" &&
+    cmake c:\projects\source -DCMAKE_BUILD_TYPE=Debug -DDEAL_II_CXX_FLAGS="-WX" -G "Visual Studio 16 2019" -DCMAKE_INSTALL_PREFIX="c:\projects\dealii" &&
     cmake --build . --target install -- -m
 
 for:
diff --git a/include/deal.II/matrix_free/evaluation_kernels.h b/include/deal.II/matrix_free/evaluation_kernels.h
index e4f27720e1..edd77e77a8 100644
--- a/include/deal.II/matrix_free/evaluation_kernels.h
+++ b/include/deal.II/matrix_free/evaluation_kernels.h
@@ -1907,7 +1907,7 @@ namespace internal
 
       VectorizedArrayType
                            temp_data[static_dofs_per_face < stack_array_size_threshold ?
-                    n_components * 2 * static_dofs_per_face :
+                    n_components * 2ull * static_dofs_per_face :
                     1];
       VectorizedArrayType *temp1;
       if (static_dofs_per_face < stack_array_size_threshold)