From: Timo Heister Date: Tue, 17 Mar 2020 18:27:10 +0000 (-0400) Subject: address comment X-Git-Tag: v9.2.0-rc1~409^2 X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=60f15fa6202b246850b9671364beb12bbe0a1a39;p=dealii.git address comment --- diff --git a/cmake/checks/check_01_cxx_features.cmake b/cmake/checks/check_01_cxx_features.cmake index a723c66d37..17aeeae4bc 100644 --- a/cmake/checks/check_01_cxx_features.cmake +++ b/cmake/checks/check_01_cxx_features.cmake @@ -731,14 +731,15 @@ CHECK_CXX_SOURCE_COMPILES( # expression, C++14 allows to call non-constexpr functions from constexpr # functions. # -# Only run this check if we have CXX14 support, otherwise the use of constexpr -# is limited (non-const constexp functions for example). -# # Unfortunately, not all compilers obey the standard in this regard. In some # cases, MSVC 2019 crashes with an internal compiler error when we # declare the respective functions as 'constexpr' even though the test below # passes, see #9080. # +# We only run this check if we have CXX14 support, otherwise the use of constexpr +# is limited (non-const constexpr functions for example). +# +# IF(DEAL_II_WITH_CXX14 AND NOT CMAKE_CXX_COMPILER_ID MATCHES "MSVC") CHECK_CXX_SOURCE_COMPILES( "