From: Matthias Maier <tamiko@43-1.org>
Date: Sat, 16 May 2020 18:15:10 +0000 (-0500)
Subject: mark code snippet as workaround slated for removal
X-Git-Tag: v9.2.0-rc3~7^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6dd41d86ca399a212e3e1d4cd458d784c4c83311;p=dealii.git

mark code snippet as workaround slated for removal
---

diff --git a/include/deal.II/base/symmetric_tensor.h b/include/deal.II/base/symmetric_tensor.h
index ea6599ec13..204d8f3c17 100644
--- a/include/deal.II/base/symmetric_tensor.h
+++ b/include/deal.II/base/symmetric_tensor.h
@@ -72,6 +72,11 @@ DEAL_II_CONSTEXPR inline DEAL_II_ALWAYS_INLINE Number
 
 namespace internal
 {
+  // Workaround: The following 4 overloads are necessary to be able to
+  // compile the library with Apple Clang 8 and older. We should remove
+  // these overloads again when we bump the minimal required version to
+  // something later than clang-3.6 / Apple Clang 6.3.
+  // - Jean-Paul Pelteret, Matthias Maier, Daniel Arndt 2020
   template <int rank, int dim, typename T, typename U>
   struct ProductTypeImpl<SymmetricTensor<rank, dim, T>, std::complex<U>>
   {
@@ -81,7 +86,6 @@ namespace internal
                       std::complex<typename ProductType<T, U>::type>>;
   };
 
-
   template <int rank, int dim, typename T, typename U>
   struct ProductTypeImpl<SymmetricTensor<rank, dim, std::complex<T>>,
                          std::complex<U>>
@@ -110,6 +114,7 @@ namespace internal
                       dim,
                       std::complex<typename ProductType<T, U>::type>>;
   };
+  // end workaround
 
   /**
    * A namespace for functions and classes that are internal to how the
diff --git a/include/deal.II/base/tensor.h b/include/deal.II/base/tensor.h
index 61435d45a0..9580b92999 100644
--- a/include/deal.II/base/tensor.h
+++ b/include/deal.II/base/tensor.h
@@ -789,6 +789,11 @@ private:
 #ifndef DOXYGEN
 namespace internal
 {
+  // Workaround: The following 4 overloads are necessary to be able to
+  // compile the library with Apple Clang 8 and older. We should remove
+  // these overloads again when we bump the minimal required version to
+  // something later than clang-3.6 / Apple Clang 6.3.
+  // - Jean-Paul Pelteret, Matthias Maier, Daniel Arndt 2020
   template <int rank, int dim, typename T, typename U>
   struct ProductTypeImpl<Tensor<rank, dim, T>, std::complex<U>>
   {
@@ -816,6 +821,7 @@ namespace internal
     using type =
       Tensor<rank, dim, std::complex<typename ProductType<T, U>::type>>;
   };
+  // end workaround
 
   /**
    * The structs below are needed to initialize nested Tensor objects.