From: David Wells <drwells@email.unc.edu>
Date: Mon, 6 Feb 2023 00:04:09 +0000 (-0500)
Subject: Clean up some orientation code.
X-Git-Tag: relicensing~816^2~1
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=93e869364fd735e674b496a9b0552348cdd22745;p=dealii.git

Clean up some orientation code.
---

diff --git a/source/base/qprojector.cc b/source/base/qprojector.cc
index 4edf929662..8d3a1261bd 100644
--- a/source/base/qprojector.cc
+++ b/source/base/qprojector.cc
@@ -1330,10 +1330,13 @@ QProjector<dim>::DataSetDescriptor::face(const ReferenceCell &reference_cell,
                 n_quadrature_points};
       else if (dim == 3)
         {
-          const unsigned int orientation = (face_flip ? 4 : 0) +
-                                           (face_rotation ? 2 : 0) +
-                                           (face_orientation ? 1 : 0);
-          return {(6 * face_no + orientation) * n_quadrature_points};
+          const unsigned char orientation = (face_flip ? 4 : 0) +
+                                            (face_rotation ? 2 : 0) +
+                                            (face_orientation ? 1 : 0);
+          Assert(orientation < 6, ExcInternalError());
+          return {(reference_cell.n_face_orientations(face_no) * face_no +
+                   orientation) *
+                  n_quadrature_points};
         }
     }