From: David Wells Date: Tue, 2 Jun 2015 21:19:43 +0000 (-0400) Subject: Remove 'dummy' members and allow empty structs. X-Git-Tag: v8.3.0-rc1~129^2~1 X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=95a559524180b4feaf2de760052d6fdd3d03dd55;p=dealii.git Remove 'dummy' members and allow empty structs. Empty structs are implementation-dependent in C, but are acceptable in C++. Therefore unused private members are not needed (and they cause clang to generate warnings). --- diff --git a/include/deal.II/base/data_out_base.h b/include/deal.II/base/data_out_base.h index 768ab37217..a8e47c9a32 100644 --- a/include/deal.II/base/data_out_base.h +++ b/include/deal.II/base/data_out_base.h @@ -509,15 +509,7 @@ namespace DataOutBase * @ingroup output */ struct GnuplotFlags : public OutputFlagsBase - { - private: - /** - * Dummy entry to suppress compiler warnings when copying an empty - * structure. Remove this member when adding the first flag to this - * structure (and remove the private as well). - */ - int dummy; - }; + {}; /** * Flags controlling the details of output in Povray format. Several flags @@ -816,15 +808,7 @@ namespace DataOutBase * @ingroup output */ struct GmvFlags : public OutputFlagsBase - { - private: - /** - * Dummy entry to suppress compiler warnings when copying an empty - * structure. Remove this member when adding the first flag to this - * structure (and remove the private as well). - */ - int dummy; - }; + {}; /** * Flags controlling the details of output in Tecplot format. @@ -977,14 +961,6 @@ namespace DataOutBase * what the current readers and writers understand. */ static const unsigned int format_version = 3; - - private: - /** - * Dummy entry to suppress compiler warnings when copying an empty - * structure. Remove this member when adding the first flag to this - * structure (and remove the private as well). - */ - int dummy; }; /**