From: Marco Feder <marco.feder@sissa.it>
Date: Wed, 5 Jul 2023 07:21:01 +0000 (+0200)
Subject: Use ifdef
X-Git-Tag: relicensing~677^2~8
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9d784c5ef98f26061048ac1977e13c994bb44fd7;p=dealii.git

Use ifdef
---

diff --git a/source/grid/grid_tools.cc b/source/grid/grid_tools.cc
index 82a58c6e0a..ece105741a 100644
--- a/source/grid/grid_tools.cc
+++ b/source/grid/grid_tools.cc
@@ -5888,93 +5888,100 @@ namespace GridTools
       std::vector<std::pair<unsigned int, unsigned int>> ranks_and_indices;
       ranks_and_indices.reserve(entities.size());
 
-#if defined(DEAL_II_WITH_ARBORX)
-#  define USE_ARBORX true
-#else
-#  define USE_ARBORX false
-#endif
-
-      if constexpr (USE_ARBORX == false)
+#if !defined(DEAL_II_WITH_ARBORX)
+      std::vector<std::vector<BoundingBox<spacedim>>> global_bboxes_temp;
+      auto *global_bboxes_to_be_used = &global_bboxes;
+      if (global_bboxes.size() == 1)
         {
-          std::vector<std::vector<BoundingBox<spacedim>>> global_bboxes_temp;
-          auto *global_bboxes_to_be_used = &global_bboxes;
-          if (global_bboxes.size() == 1)
-            {
-              global_bboxes_temp =
-                Utilities::MPI::all_gather(comm, global_bboxes[0]);
-              global_bboxes_to_be_used = &global_bboxes_temp;
-            }
+          global_bboxes_temp =
+            Utilities::MPI::all_gather(comm, global_bboxes[0]);
+          global_bboxes_to_be_used = &global_bboxes_temp;
+        }
 
 
-          // helper function to determine if a bounding box is valid
-          const auto is_valid = [](const auto &bb) {
-            for (unsigned int i = 0; i < spacedim; ++i)
-              if (bb.get_boundary_points().first[i] >
-                  bb.get_boundary_points().second[i])
-                return false;
+      // helper function to determine if a bounding box is valid
+      const auto is_valid = [](const auto &bb) {
+        for (unsigned int i = 0; i < spacedim; ++i)
+          if (bb.get_boundary_points().first[i] >
+              bb.get_boundary_points().second[i])
+            return false;
 
-            return true;
-          };
+        return true;
+      };
 
-          // linearize vector of vectors
-          std::vector<std::pair<BoundingBox<spacedim>, unsigned int>>
-            boxes_and_ranks;
+      // linearize vector of vectors
+      std::vector<std::pair<BoundingBox<spacedim>, unsigned int>>
+        boxes_and_ranks;
 
-          for (unsigned rank = 0; rank < global_bboxes_to_be_used->size();
-               ++rank)
-            for (const auto &box : (*global_bboxes_to_be_used)[rank])
-              if (is_valid(box))
-                boxes_and_ranks.emplace_back(box, rank);
+      for (unsigned rank = 0; rank < global_bboxes_to_be_used->size(); ++rank)
+        for (const auto &box : (*global_bboxes_to_be_used)[rank])
+          if (is_valid(box))
+            boxes_and_ranks.emplace_back(box, rank);
 
-          // pack boxes into r-tree
-          const auto tree = pack_rtree(boxes_and_ranks);
+      // pack boxes into r-tree
+      const auto tree = pack_rtree(boxes_and_ranks);
 
-          // loop over all entities
-          for (unsigned int i = 0; i < entities.size(); ++i)
-            {
-              // create a bounding box with tolerance
-              const auto bb =
-                BoundingBox<spacedim>(entities[i]).create_extended(tolerance);
+      // loop over all entities
+      for (unsigned int i = 0; i < entities.size(); ++i)
+        {
+          // create a bounding box with tolerance
+          const auto bb =
+            BoundingBox<spacedim>(entities[i]).create_extended(tolerance);
 
-              // determine ranks potentially owning point/bounding box
-              std::set<unsigned int> my_ranks;
+          // determine ranks potentially owning point/bounding box
+          std::set<unsigned int> my_ranks;
 
-              for (const auto &box_and_rank :
-                   tree | boost::geometry::index::adaptors::queried(
-                            boost::geometry::index::intersects(bb)))
-                my_ranks.insert(box_and_rank.second);
+          for (const auto &box_and_rank :
+               tree | boost::geometry::index::adaptors::queried(
+                        boost::geometry::index::intersects(bb)))
+            my_ranks.insert(box_and_rank.second);
 
-              for (const auto rank : my_ranks)
-                ranks_and_indices.emplace_back(rank, i);
-            }
+          for (const auto rank : my_ranks)
+            ranks_and_indices.emplace_back(rank, i);
         }
-      else if constexpr (USE_ARBORX == true)
+
+#else
+
+      auto fill_ranks_and_indices =
+        [&ranks_and_indices](
+          const std::vector<int> &                offsets,
+          const std::vector<std::pair<int, int>> &indices_ranks) {
+          for (unsigned int i = 0; i < offsets.size() - 1; ++i)
+            for (int j = offsets[i]; j < offsets[i + 1]; ++j)
+              ranks_and_indices.emplace_back(indices_ranks[j].second, i);
+        };
+
+      unsigned int idx = (global_bboxes.size() == 1) ?
+                           0 :
+                           Utilities::MPI::this_mpi_process(comm);
+      // size of global_bboxes>1
+      if constexpr (spacedim == 2)
         {
-          auto fill_ranks_and_indices =
-            [&ranks_and_indices](
-              const std::vector<int> &                offsets,
-              const std::vector<std::pair<int, int>> &indices_ranks) {
-              for (unsigned int i = 0; i < offsets.size() - 1; ++i)
-                for (int j = offsets[i]; j < offsets[i + 1]; ++j)
-                  ranks_and_indices.emplace_back(indices_ranks[j].second, i);
-            };
+          // Create query bounding boxes out of entities
+          std::vector<BoundingBox<2>> query_bounding_boxes;
+          for (const auto &entity : entities)
+            query_bounding_boxes.push_back(
+              BoundingBox<2>(entity).create_extended(tolerance));
+          ArborXWrappers::BoundingBoxIntersectPredicate bb_intersect(
+            query_bounding_boxes);
+
+          ArborXWrappers::DistributedTree distributed_tree(comm,
+                                                           global_bboxes[idx]);
+
+          auto indices_ranks_offset = distributed_tree.query(bb_intersect);
+          auto indices_ranks        = indices_ranks_offset.first;
+          auto offsets              = indices_ranks_offset.second;
+
+          fill_ranks_and_indices(offsets, indices_ranks);
+        }
+      else if constexpr (spacedim == 3)
+        {
+          ArborXWrappers::DistributedTree distributed_tree(comm,
+                                                           global_bboxes[idx]);
 
-          unsigned int idx = (global_bboxes.size() == 1) ?
-                               0 :
-                               Utilities::MPI::this_mpi_process(comm);
-          // size of global_bboxes>1
-          if constexpr (spacedim == 2)
+          if constexpr (std::is_same<T, Point<3>>::value)
             {
-              // Create query bounding boxes out of entities
-              std::vector<BoundingBox<2>> query_bounding_boxes;
-              for (const auto &entity : entities)
-                query_bounding_boxes.push_back(
-                  BoundingBox<2>(entity).create_extended(tolerance));
-              ArborXWrappers::BoundingBoxIntersectPredicate bb_intersect(
-                query_bounding_boxes);
-
-              ArborXWrappers::DistributedTree distributed_tree(
-                comm, global_bboxes[idx]);
+              ArborXWrappers::PointIntersectPredicate bb_intersect(entities);
 
               auto indices_ranks_offset = distributed_tree.query(bb_intersect);
               auto indices_ranks        = indices_ranks_offset.first;
@@ -5982,42 +5989,20 @@ namespace GridTools
 
               fill_ranks_and_indices(offsets, indices_ranks);
             }
-          else if constexpr (spacedim == 3)
+          else if constexpr (std::is_same<T, BoundingBox<3>>::value)
             {
-              ArborXWrappers::DistributedTree distributed_tree(
-                comm, global_bboxes[idx]);
-
-              if constexpr (std::is_same<T, Point<3>>::value)
-                {
-                  ArborXWrappers::PointIntersectPredicate bb_intersect(
-                    entities);
-
-                  auto indices_ranks_offset =
-                    distributed_tree.query(bb_intersect);
-                  auto indices_ranks = indices_ranks_offset.first;
-                  auto offsets       = indices_ranks_offset.second;
-
-                  fill_ranks_and_indices(offsets, indices_ranks);
-                }
-              else if constexpr (std::is_same<T, BoundingBox<3>>::value)
-                {
-                  ArborXWrappers::BoundingBoxIntersectPredicate bb_intersect(
-                    entities);
+              ArborXWrappers::BoundingBoxIntersectPredicate bb_intersect(
+                entities);
 
-                  auto indices_ranks_offset =
-                    distributed_tree.query(bb_intersect);
-                  auto indices_ranks = indices_ranks_offset.first;
-                  auto offsets       = indices_ranks_offset.second;
+              auto indices_ranks_offset = distributed_tree.query(bb_intersect);
+              auto indices_ranks        = indices_ranks_offset.first;
+              auto offsets              = indices_ranks_offset.second;
 
-                  fill_ranks_and_indices(offsets, indices_ranks);
-                }
+              fill_ranks_and_indices(offsets, indices_ranks);
             }
         }
-      else
-        {
-          // We should never get here:
-          AssertThrow(false, ExcInternalError());
-        }
+
+#endif
 
       // convert to CRS
       std::sort(ranks_and_indices.begin(), ranks_and_indices.end());