From: Matthias Maier <tamiko@43-1.org>
Date: Thu, 10 May 2018 09:19:35 +0000 (-0500)
Subject: CMake: Do not set -Wsuggest-override in the project configuration
X-Git-Tag: v9.1.0-rc1~1157^2
X-Git-Url: https://gitweb.dealii.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cbe51b04eb12026d53cb0522f92c8a67f25a574d;p=dealii.git

CMake: Do not set -Wsuggest-override in the project configuration
---

diff --git a/cmake/config/CMakeLists.txt b/cmake/config/CMakeLists.txt
index 21d43f0d8f..5d9cce0a5c 100644
--- a/cmake/config/CMakeLists.txt
+++ b/cmake/config/CMakeLists.txt
@@ -74,8 +74,17 @@ STRIP_FLAG(DEAL_II_LINKER_FLAGS "-Wl,--as-needed")
 # Strip -Wno-deprecated-declarations from DEAL_II_CXX_FLAGS so that
 # deprecation warnings are actually shown for user code:
 #
+
 STRIP_FLAG(DEAL_II_CXX_FLAGS "-Wno-deprecated-declarations")
 
+#
+# Strip -Wsuggest-override. Enabling this warning is a stylistic choice
+# that might create a substantial amount of warnings in user codebases.
+# Let's be nice and disable the flag for now.
+#
+
+STRIP_FLAG(DEAL_II_CXX_FLAGS "-Wsuggest-override")
+
 #
 # Populate a bunch of CONFIG_* variables with useful information:
 #